linux-kernel - Re: [PATCH v2] PCI: endpoint: Set RX DMA channel to NULL after freeing it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241227135948.ztxxx2u37og3ixxn@thinkpad>
Date: Fri, 27 Dec 2024 19:29:48 +0530
From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To: Mohamed Khalfella <khalfella@...il.com>
Cc: Krzysztof Wilczyński <kw@...ux.com>,
	Kishon Vijay Abraham I <kishon@...nel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Niklas Cassel <cassel@...nel.org>, Frank Li <Frank.Li@....com>,
	Damien Le Moal <dlemoal@...nel.org>,
	Wang Jiang <jiangwang@...inos.cn>,
	Krzysztof Wilczyński <kwilczynski@...nel.org>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] PCI: endpoint: Set RX DMA channel to NULL after
 freeing it

On Thu, Dec 26, 2024 at 09:51:37AM -0800, Mohamed Khalfella wrote:
> On 2024-12-26 22:01:21 +0530, Manivannan Sadhasivam wrote:
> > On Sat, Dec 21, 2024 at 09:34:42AM -0800, Mohamed Khalfella wrote:
> > > Fix a small bug in pci-epf-test driver. When requesting TX DMA channel
> > > fails, free already allocated RX channel and set it to NULL.
> > > 
> > 
> > Patch description should accurately describe what the patch does. Here, the
> > patch is fixing the NULL ptr assignment to dma_chan_rx pointer and that's it.
> > 
> > Reword it as such.
> 
> PCI: endpoint: pci-epf-test: Fix NULL ptr assignment to dma_chan_rx
> 
> When allocating dma_chan_tx fails set dma_chan_rx to NULL after it is
> freed.
> 

s/"When allocating dma_chan_tx fails"/"If dma_chan_tx allocation fails,"

- Mani

-- 
மணிவண்ணன் சதாசிவம்