linux-kernel - Re: [PATCH] dt-bindings: phy: add rk3576 hdptx phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <af945132-1ff3-41bd-a958-4241a9d171d5@kernel.org>
Date: Sat, 28 Dec 2024 10:36:59 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Andy Yan <andyshrk@....com>
Cc: heiko@...ech.de, cristian.ciocaltea@...labora.com,
 detlev.casanova@...labora.com, krzk+dt@...nel.org, vkoul@...nel.org,
 kishon@...nel.org, robh@...nel.org, sebastian.reichel@...labora.com,
 linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-rockchip@...ts.infradead.org, Andy Yan <andy.yan@...k-chips.com>
Subject: Re: [PATCH] dt-bindings: phy: add rk3576 hdptx phy

On 27/12/2024 11:46, Andy Yan wrote:
>>
>>> +              - rockchip,rk3576-hdptx-phy
>>
>> So that's just enum with previous entry... but you said compatible, yet
>> nothing is here. Test your patches - DTS will fail on this. Driver as
>> well (assuming you expressed properly compatibility).
> 
> Is this the right way to write it ？：
> 
> properties:
>    compatible:
> -    enum:
> -      - rockchip,rk3588-hdptx-phy
> +    oneOf:
> +      - enum:
> +          - rockchip,rk3588-hdptx-phy
> +      - items:
> +          - enum:
> +              - rockchip,rk3576-hdptx-phy
> +          - const: rockchip,rk3588-hdptx-phy

Yes, assuming they are compatible.

Best regards,
Krzysztof