linux-kernel - Re: [PATCH v2] pinctrl: bcm63268: add gpio function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKR-sGeVfd4VttzycUXMZDi=5eGYmQ8f5PfzQkgb_EF1cFqXiw@mail.gmail.com>
Date: Sat, 28 Dec 2024 10:47:50 +0100
From: Álvaro Fernández Rojas <noltari@...il.com>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, 
	Florian Fainelli <florian.fainelli@...adcom.com>, kylehendrydev@...il.com, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	"open list:MIPS" <linux-mips@...r.kernel.org>, Jonas Gorski <jonas.gorski@...il.com>
Subject: Re: [PATCH v2] pinctrl: bcm63268: add gpio function

El vie, 27 dic 2024 a las 17:17, Linus Walleij
(<linus.walleij@...aro.org>) escribió:
>
> On Tue, Dec 24, 2024 at 11:36 AM Álvaro Fernández Rojas
> <noltari@...il.com> wrote:
>
> > From: Kyle Hendry <kylehendrydev@...il.com>
> >
> > There is no guarantee that the bootloader will leave the pin configuration
> > in a known default state, so pinctrl needs to be explicitly set in some
> > cases. This patch adds a gpio function for drivers that need it, i.e.
> > gpio-leds.
> >
> > Signed-off-by: Kyle Hendry <kylehendrydev@...il.com>
> > Signed-off-by: Álvaro Fernández Rojas <noltari@...il.com>
>
> This looks right to me, but can we get some review from some
> of the Broadcom people? (Hm it's MIPS so I guess that means
> Florian.)
>
> Yours,
> Linus Walleij

Thanks Linus :)

BTW, I think that other bcm63xx pinctrl drivers need that fix too (or
at least bcm6362).
Can anyone confirm it?

Best regards,
Álvaro.