linux-kernel - Re: [PATCH] staging: greybus: Log driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024122946-footer-neatness-aeb9@gregkh>
Date: Sun, 29 Dec 2024 11:19:55 +0100
From: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To: Steven Davis <goldside000@...look.com>
Cc: "johan@...nel.org" <johan@...nel.org>,
	"elder@...nel.org" <elder@...nel.org>,
	"greybus-dev@...ts.linaro.dev" <greybus-dev@...ts.linaro.dev>,
	"linux-staging@...ts.linux.dev" <linux-staging@...ts.linux.dev>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: greybus: Log driver_register() failure

On Sat, Dec 28, 2024 at 04:57:44PM +0000, Steven Davis wrote:
> Currently, if driver_register() fails, it just returns retval
> and fails silently. This behavior may make the error more difficult
> to debug, as the error is not logged.
> 
> Adding pr_err() here will log the error descriptively, along with
> driver name and the value that retval returned. That way, the error
> is not silent and the user can see what happened.
> 
> Signed-off-by: Steven Davis <goldside000@...look.com>
> ---
>  drivers/staging/greybus/gbphy.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c
> index 6adcad286..c6d1030b7 100644
> --- a/drivers/staging/greybus/gbphy.c
> +++ b/drivers/staging/greybus/gbphy.c
> @@ -204,8 +204,10 @@ int gb_gbphy_register_driver(struct gbphy_driver *driver,
>  	driver->driver.mod_name = mod_name;
>  
>  	retval = driver_register(&driver->driver);
> -	if (retval)
> +	if (retval) {
> +		pr_err("failed to register driver %s: %d\n", driver->name, retval);

Is this really an issue in real-world situations?  Have you run across
this where this failed and knowing the return value of driver_register()
helped out?

And if you are using this driver, great!  Let's get it cleaned up and
out of drivers/staging/ please!  Otherwise we really should just remove
them :(

thanks,

greg k-h