linux-kernel - Re: [PATCH v2] staging: rtl8723bs: fix network selection in rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024122947-observant-nature-d4cf@gregkh>
Date: Sun, 29 Dec 2024 11:21:38 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Atharva Tiwari <evepolonium@...il.com>
Cc: Meir Elisha <meir6264@...il.com>,
	Philipp Hortmann <philipp.g.hortmann@...il.com>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: fix network selection in
 rtw_mlme.c (completing todo)

On Thu, Dec 26, 2024 at 06:30:24PM +0530, Atharva Tiwari wrote:
> this patch fixes the network selection logic to avoid selecting a network
> with the same ESSID as the olddest scanned network if it was scanned
> within the last 500 millisecounds
> 
> and please give a specific value for "new enough" on line 481,
> i have estimated 500 millisecound but inform me if the value
> needs to be changed

Why is this paragraph in a changelog?  How is that going to work?

> 
> Signed-off-by: Atharva Tiwari <evepolonium@...il.com>
> ---
> Changes since v1:
> - Changed the "new enough" value from 1000 millisecounds to 500
> - fixed some styling issue

You sent 4 copies of this, on different days, so I have no idea what the
"correct" one is :(

Please fix this up and send a v3 showing what is different from previous
versions and only send one copy.

thanks,

greg k-h