linux-kernel - Re: [PATCH 2/5] platform: arm64: add Huawei Matebook E Go (sc8280xp) EC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48c2ea99-ef86-48a9-8b16-38fe47ed7f75@kernel.org>
Date: Sun, 29 Dec 2024 10:44:52 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pengyu Luo <mitltlatltl@...il.com>, dmitry.baryshkov@...aro.org
Cc: andersson@...nel.org, bryan.odonoghue@...aro.org, conor+dt@...nel.org,
 devicetree@...r.kernel.org, gregkh@...uxfoundation.org, hdegoede@...hat.com,
 heikki.krogerus@...ux.intel.com, ilpo.jarvinen@...ux.intel.com,
 konradybcio@...nel.org, krzk+dt@...nel.org, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-usb@...r.kernel.org, nikita@...n.ru,
 platform-driver-x86@...r.kernel.org, robh@...nel.org, sre@...nel.org
Subject: Re: [PATCH 2/5] platform: arm64: add Huawei Matebook E Go (sc8280xp)
 EC driver

On 29/12/2024 10:04, Pengyu Luo wrote:
>>>>> +
>>>>> +struct gaokun_ec;
>>>>> +struct notifier_block;
>>>>
>>>> Drop, include proper header instead.
>>>>
>>>
>>> I agree, I copy 'struct notifier_block;' from
>>> include/linux/platform_data/lenovo-yoga-c630.h
>>
>> Please don't pollute header files with extra dependencies. It's usually
>> better to just forware-declare the struct instead of adding unnecessary
>> include.
>>
> 
> Both of you are resonable. So how?
> 
> BTW, Krzysztof said

I would recommend differently, but I am fine with other approach if
other reviewers have their preference.

> 
>>> You need kerneldoc, in the C file, for all exported functions.
> 
> So Dmitry is here, I want to check again, should I add kerneldoc for all
> exported functions? C630 one never added all kerneldocs. In my driver,
> some function names have already indicated many things, some complex
> functions have been doced.
Best regards,
Krzysztof