linux-kernel - Re: [PATCH 1/5] dt-bindings: platform: Add Huawei Matebook E Go EC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff53d7f7-0103-4e52-ac0a-c05bf4521cd1@kernel.org>
Date: Sun, 29 Dec 2024 10:50:08 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pengyu Luo <mitltlatltl@...il.com>
Cc: andersson@...nel.org, bryan.odonoghue@...aro.org, conor+dt@...nel.org,
 devicetree@...r.kernel.org, dmitry.baryshkov@...aro.org,
 gregkh@...uxfoundation.org, hdegoede@...hat.com,
 heikki.krogerus@...ux.intel.com, ilpo.jarvinen@...ux.intel.com,
 konradybcio@...nel.org, krzk+dt@...nel.org, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-usb@...r.kernel.org, nikita@...n.ru,
 platform-driver-x86@...r.kernel.org, robh@...nel.org, sre@...nel.org
Subject: Re: [PATCH 1/5] dt-bindings: platform: Add Huawei Matebook E Go EC

On 28/12/2024 11:50, Pengyu Luo wrote:
> On Sat, Dec 28, 2024 at 5:54 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>> On 27/12/2024 18:13, Pengyu Luo wrote:
>>> +
>>> +description:
>>> +  Different from other Qualcomm Snapdragon sc8180x sc8280xp based machines,
>>> +  the Huawei Matebook E Go tablets use embedded controllers while others
>>> +  use something called pmic glink which handles battery, UCSI, USB Type-C DP
>>> +  alt mode. Huawei one handles even more, like charging thresholds, FN lock,
>>> +  lid status, HPD events for the USB Type-C DP alt mode, etc.
>>> +
>>> +properties:
>>> +  compatible:
>>> +    items:
>>> +      - enum:
>>> +          - huawei,sc8180x-gaokun-ec
>>> +          - huawei,sc8280xp-gaokun-ec
>>
>> sc8180x and sc8280xp are not products of Huawei, so you cannot combine
>> them. Use compatibles matching exactly your device, because I doubt any
>> of us has actual schematics or datasheet of that device.
>>
>>> +      - const: huawei,gaokun-ec
>>
>> How did you get the name?
>>
> 
> From website of Huawei([1]), please search for 'gaokun' here, we can know

Then please explain this in commit msg or bindings description (what is
gaokun).

> this series is called gaokun. Many files from windows indicate more,
> someone fetch drivers from microsoft server([2]), in one of driver archive
> 'OemXAudioExt_HWVE.cab', there are two files, "algorithm_GaoKunGen2.xml"
> "algorithm_GaoKunGen3.xml". And `Gaokun Gen3` print can be found on
> motherboard(someone have the motherboard, I can ask for it later).
> 
> So can I use?
> - enum:
> 	- huawei,gaokun-gen2
> 	- huawei,gaokun-gen3

The internal name?

> 
> Some backgroud:
> There are 3 variants, Huawei released first 2 at the same time.
> Huawei Matebook E Go LTE(sc8180x), codename should be gaokun2.
> Huawei Matebook E Go(sc8280xp@...GHz), codename is gaokun3.
> Huawei Matebook E Go 2023(sc8280xp@...9GHz).

Well, I believe it is still not good choice because we have absolutely
zero insights what is actually there, what else is called gaokun etc.
Especially "gen2" and "gen3" - how can anyone, outside of Huawei, figure
out which is gen3?

Why do people try to decode some vendor naming scheme instead of using
well recognized, public and available naming: the device name?


Best regards,
Krzysztof