linux-kernel - Re: [PATCH 3/6] mtd: st_spi_fsm: Switch from CONFIG_PM_SLEEP guards to pm_sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877c7ha77n.fsf@bootlin.com>
Date: Mon, 30 Dec 2024 09:46:52 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Raphael Gallais-Pou <rgallaispou@...il.com>
Cc: Patrice Chotard <patrice.chotard@...s.st.com>,  Thinh Nguyen
 <Thinh.Nguyen@...opsys.com>,  Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>,  Adrian Hunter <adrian.hunter@...el.com>,
  Ulf Hansson <ulf.hansson@...aro.org>,  Richard Weinberger
 <richard@....at>,  Vignesh Raghavendra <vigneshr@...com>,  Damien Le Moal
 <dlemoal@...nel.org>,  Niklas Cassel <cassel@...nel.org>,  Alexandre
 Torgue <alexandre.torgue@...s.st.com>,  Jose Abreu <joabreu@...opsys.com>,
  Andrew Lunn <andrew+netdev@...n.ch>,  "David S. Miller"
 <davem@...emloft.net>,  Eric Dumazet <edumazet@...gle.com>,  Jakub
 Kicinski <kuba@...nel.org>,  Paolo Abeni <pabeni@...hat.com>,  Maxime
 Coquelin <mcoquelin.stm32@...il.com>,  Mark Brown <broonie@...nel.org>,
  linux-arm-kernel@...ts.infradead.org,  linux-usb@...r.kernel.org,
  linux-kernel@...r.kernel.org,  linux-mmc@...r.kernel.org,
  linux-mtd@...ts.infradead.org,  linux-ide@...r.kernel.org,
  netdev@...r.kernel.org,  linux-stm32@...md-mailman.stormreply.com,
  linux-spi@...r.kernel.org
Subject: Re: [PATCH 3/6] mtd: st_spi_fsm: Switch from CONFIG_PM_SLEEP guards
 to pm_sleep_ptr()

Hello Raphael,

On 29/12/2024 at 00:32:42 +01, Raphael Gallais-Pou <rgallaispou@...il.com> wrote:

> Letting the compiler remove these functions when the kernel is built
> without CONFIG_PM_SLEEP support is simpler and less error prone than the
> use of #ifdef based kernel configuration guards.

If that does not lead to any warning, I'm fine. However this kind of
change is better received subsystem-wide than platform-wide, if you ever
wish to go this route.

> Link: https://lore.kernel.org/all/20240716180010.126987-1-rgallaispou@gmail.com

This link however seems irrelevant.

> Signed-off-by: Raphael Gallais-Pou <rgallaispou@...il.com>

Thanks,
Miquèl