linux-kernel - Re: [PATCH] ARM: dts: amlogic: meson: remove size and address cells from USB nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e08e5be6-9d0e-4d32-9d67-eec57634f6db@linaro.org>
Date: Mon, 30 Dec 2024 10:55:29 +0100
From: neil.armstrong@...aro.org
To: Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
 linux-amlogic@...ts.infradead.org
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: amlogic: meson: remove size and address cells
 from USB nodes

On 26/12/2024 23:03, Martin Blumenstingl wrote:
> The only board that actually requires these properties is
> meson8b-odroidc1.dts but that already sets it on it's own. Drop these
> properties from meson.dtsi because otherwise they can cause dtc
> warnings:
>    /soc/usb@...40000: unnecessary #address-cells/#size-cells without
>    "ranges", "dma-ranges" or child "reg" property
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> ---
>   arch/arm/boot/dts/amlogic/meson.dtsi | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/amlogic/meson.dtsi b/arch/arm/boot/dts/amlogic/meson.dtsi
> index 8cb0fc78b2af..28ec2c821cdc 100644
> --- a/arch/arm/boot/dts/amlogic/meson.dtsi
> +++ b/arch/arm/boot/dts/amlogic/meson.dtsi
> @@ -255,8 +255,6 @@ rtc: rtc@740 {
>   
>   		usb0: usb@...40000 {
>   			compatible = "snps,dwc2";
> -			#address-cells = <1>;
> -			#size-cells = <0>;
>   			reg = <0xc9040000 0x40000>;
>   			interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
>   			phys = <&usb0_phy>;
> @@ -270,8 +268,6 @@ usb0: usb@...40000 {
>   
>   		usb1: usb@...c0000 {
>   			compatible = "snps,dwc2";
> -			#address-cells = <1>;
> -			#size-cells = <0>;
>   			reg = <0xc90c0000 0x40000>;
>   			interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
>   			phys = <&usb1_phy>;

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>