linux-kernel - Re: [PATCH v3 1/7] dt-bindings: mailbox: mediatek: Add MT8196 support for gce-mailbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11d058874ec4d9302bbc25a69a8de63e56dc8f64.camel@mediatek.com>
Date: Mon, 30 Dec 2024 02:25:02 +0000
From: Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>
To: "krzk@...nel.org" <krzk@...nel.org>
CC: Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>, "robh@...nel.org"
	<robh@...nel.org>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "simona@...ll.ch" <simona@...ll.ch>,
	"mchehab@...nel.org" <mchehab@...nel.org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "chunkuang.hu@...nel.org"
	<chunkuang.hu@...nel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "jassisinghbrar@...il.com"
	<jassisinghbrar@...il.com>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	Singo Chang (張興國) <Singo.Chang@...iatek.com>,
	Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "airlied@...il.com"
	<airlied@...il.com>, "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
	Xavier Chang (張獻文) <Xavier.Chang@...iatek.com>,
	Moudy Ho (何宗原) <Moudy.Ho@...iatek.com>
Subject: Re: [PATCH v3 1/7] dt-bindings: mailbox: mediatek: Add MT8196 support
 for gce-mailbox

Hi Krzysztof,

On Fri, 2024-12-27 at 09:11 +0100, Krzysztof Kozlowski wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Fri, Dec 20, 2024 at 01:07:54AM +0800, Jason-JH.Lin wrote:
> > 1. Add compatible name and iommus property to mediatek,gce-
> > mailbox.yaml
> >    for MT8196.
> > 
> >    - The compatible name "mediatek,mt8196-gce-mailbox" is added to
> >      ensure that the device tree can correctly identify and
> > configure
> 
> 
> This is 100% redundant statement. Don't state the obvious and don't
> explain to us how DT works.
> 

OK, I'll drop this.

> >      the GCE mailbox for the MT8196 SoC.
> > 
> >    - The iommus property is added to specify the IOMMU
> > configuration
> >      for the GCE mailbox, ensuring proper memory management and
> > access
> >      control.
> 
> You should say whether device supports or does not support IOMMU. So
> all
> devices now work with IOMMU? I guess I asked about it already, no
> improvements. So again, don't state the obvious.
> 

Yes, I'll change the above statement as below:

In MT8196, all the command buffers allocated and used by GCE device are
working with IOMMU.

> > 
> > 2. Add the Global Command Engine (GCE) binding header to define the
> >    abstrct symbol binding to the GCE hardware settings of GCE
> > Thread
> 
> typo

Thanks, I'll fix it.

> 
> >    Priority, GCE Subsys ID and GCE Event for MT8196.
> > 
> >    - GCE Thread Priority: Defined to configure the priority level
> > for
> >      each GCE hardware thread. This is necessary for proper
> > scheduling
> >      and execution of commands in the GCE.
> > 
> >    - GCE Subsys ID: Defined to specify the subsystem ID for GCE
> > clients.
> >      This is used to correctly address and access different
> > subsystems
> >      within the GCE.
> > 
> >    - GCE Event: Defined to specify the events that the GCE can
> > handle.
> >      These events are used by the driver to synchronize and manage
> >      hardware operations.
> > 
> >    Examples of the binding usage in the driver code:
> 
> Drop all below from commit msg. Don't paste C code into the bindings.
> 
OK, I'll drop them.

Regards,
Jason-JH.Lin

> Best regards,
> Krzysztof
>