linux-kernel - Re: [PATCH v3 3/4] media: mediatek: add MT8188 AIE driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c58790f-b1eb-4183-aafd-063dc5472b52@kernel.org>
Date: Tue, 31 Dec 2024 08:45:59 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: CK Hu (胡俊光) <ck.hu@...iatek.com>,
 "robh@...nel.org" <robh@...nel.org>, "mchehab@...nel.org"
 <mchehab@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 Bo Kong (孔波) <Bo.Kong@...iatek.com>
Cc: "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
 Project_Global_Chrome_Upstream_Group
 <Project_Global_Chrome_Upstream_Group@...iatek.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
 "matthias.bgg@...il.com" <matthias.bgg@...il.com>
Subject: Re: [PATCH v3 3/4] media: mediatek: add MT8188 AIE driver

On 27/12/2024 07:05, CK Hu (胡俊光) wrote:
> On Wed, 2024-12-25 at 17:00 +0800, bo.kong wrote:
>> From: Bo Kong <Bo.Kong@...iatek.com>
>>
>> Add a V4L2 sub-device driver for MT8188 AIE.
>>
>> Signed-off-by: Bo Kong <Bo.Kong@...iatek.com>
>> ---
> 
> [snip]
> 
>> +static void aie_reset_output_buf(struct mtk_aie_dev *fd,
>> +				 struct aie_enq_info *aie_cfg)
>> +{
> 
> Why clear output buffer?
> Could you point out which place in the output buffer that hardware does not write data into but software would read it?
> 
Please respond with one email doing review, not 10 per each comment.

Best regards,
Krzysztof