linux-kernel - Re: [PATCH v3 3/4] media: mediatek: add MT8188 AIE driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b89b90b85e7c00889595bd8b8664d564ba8dc8ca.camel@mediatek.com>
Date: Tue, 31 Dec 2024 07:57:20 +0000
From: CK Hu (胡俊光) <ck.hu@...iatek.com>
To: "robh@...nel.org" <robh@...nel.org>, "mchehab@...nel.org"
	<mchehab@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"krzk@...nel.org" <krzk@...nel.org>, Bo Kong (孔波)
	<Bo.Kong@...iatek.com>
CC: "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>, "AngeloGioacchino Del
 Regno" <angelogioacchino.delregno@...labora.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>
Subject: Re: [PATCH v3 3/4] media: mediatek: add MT8188 AIE driver

Hi, Krzysztof:

On Tue, 2024-12-31 at 08:45 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> 
> 
> On 27/12/2024 07:05, CK Hu (胡俊光) wrote:
> > On Wed, 2024-12-25 at 17:00 +0800, bo.kong wrote:
> > > From: Bo Kong <Bo.Kong@...iatek.com>
> > > 
> > > Add a V4L2 sub-device driver for MT8188 AIE.
> > > 
> > > Signed-off-by: Bo Kong <Bo.Kong@...iatek.com>
> > > ---
> > 
> > [snip]
> > 
> > > +static void aie_reset_output_buf(struct mtk_aie_dev *fd,
> > > +                             struct aie_enq_info *aie_cfg)
> > > +{
> > 
> > Why clear output buffer?
> > Could you point out which place in the output buffer that hardware does not write data into but software would read it?
> > 
> Please respond with one email doing review, not 10 per each comment.

Sorry to bother you.
I would try to respond in one email.
Even though I have new comment when second review, I would not respond so frequently.

regards,
CK

> 
> Best regards,
> Krzysztof