linux-kernel - Re: [PATCH 3/5] dt-bindings: mfd: motorola-cpcap: Document audio-codec interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34ratvyiosxtphzliv6jxcjsddk4op5745jummklumd7fyzoe4@lq4ylmrlokmr>
Date: Tue, 31 Dec 2024 09:41:33 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Tony Lindgren <tony@...mide.com>, Liam Girdwood <lgirdwood@...il.com>, 
	Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, 
	Javier Carrasco <javier.carrasco.cruz@...il.com>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-omap@...r.kernel.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH 3/5] dt-bindings: mfd: motorola-cpcap: Document
 audio-codec interrupts

On Sat, Dec 28, 2024 at 01:45:12PM +0200, Ivaylo Dimitrov wrote:
> This adds the DT binding for the audio-codec headset detection interrupts


Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

Also, missing full stop.

> 
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>
> ---
>  Documentation/devicetree/bindings/mfd/motorola-cpcap.txt | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/motorola-cpcap.txt b/Documentation/devicetree/bindings/mfd/motorola-cpcap.txt
> index 190230216de8..3ad809e119ff 100644
> --- a/Documentation/devicetree/bindings/mfd/motorola-cpcap.txt
> +++ b/Documentation/devicetree/bindings/mfd/motorola-cpcap.txt
> @@ -31,10 +31,15 @@ node must be named "audio-codec".
>  Required properties for the audio-codec subnode:
>  
>  - #sound-dai-cells = <1>;
> +- interrupts-extended = <&cpcap 9 0>, <&cpcap 10 0>;

Instead: interrupts and say which interrupt is where.

Anyway this should be converted to DT schema.

> +- interrupt-names = "hs", "mb2";
>  
>  The audio-codec provides two DAIs. The first one is connected to the
>  Stereo HiFi DAC and the second one is connected to the Voice DAC.
>  
> +audio-codec interrupts are required for jack detection, "hs" one is headset
> +detect and "mb2" is microphone bias 2 detect.

This goes to the interrupts description.

> +
>  Example:
>  
>  &mcspi1 {
> @@ -52,6 +57,10 @@ Example:
>  
>  		audio-codec {
>  			#sound-dai-cells = <1>;
> +			interrupts-extended =
> +				<&cpcap 9 0>,
> +				<&cpcap 10 0>;

Fix alignment.

Same for your DTS patches.


Best regards,
Krzysztof