linux-kernel - Re: [PATCH 3/5] dt-bindings: mfd: motorola-cpcap: Document audio-codec interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3562e162-a425-4d4a-96c5-e6b748dc87c6@gmail.com>
Date: Thu, 2 Jan 2025 10:36:36 +0200
From: Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Tony Lindgren <tony@...mide.com>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 Javier Carrasco <javier.carrasco.cruz@...il.com>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-omap@...r.kernel.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH 3/5] dt-bindings: mfd: motorola-cpcap: Document
 audio-codec interrupts



On 31.12.24 г. 10:41 ч., Krzysztof Kozlowski wrote:
> On Sat, Dec 28, 2024 at 01:45:12PM +0200, Ivaylo Dimitrov wrote:
>> This adds the DT binding for the audio-codec headset detection interrupts
> 
> 
> Please do not use "This commit/patch/change", but imperative mood. See
> longer explanation here:
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
> 
> Also, missing full stop.
> 
>>
>> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>
>> ---
>>   Documentation/devicetree/bindings/mfd/motorola-cpcap.txt | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/motorola-cpcap.txt b/Documentation/devicetree/bindings/mfd/motorola-cpcap.txt
>> index 190230216de8..3ad809e119ff 100644
>> --- a/Documentation/devicetree/bindings/mfd/motorola-cpcap.txt
>> +++ b/Documentation/devicetree/bindings/mfd/motorola-cpcap.txt
>> @@ -31,10 +31,15 @@ node must be named "audio-codec".
>>   Required properties for the audio-codec subnode:
>>   
>>   - #sound-dai-cells = <1>;
>> +- interrupts-extended = <&cpcap 9 0>, <&cpcap 10 0>;
> 
> Instead: interrupts and say which interrupt is where.
> 
> Anyway this should be converted to DT schema.
> 

Do you want me to do the conversion? If yes, could it be done in a 
follow-up patch?

Thanks and happy new year,
Ivo