| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202412311950.Ij7v1vKv-lkp@intel.com>
Date: Tue, 31 Dec 2024 20:37:10 +0800
From: kernel test robot <lkp@...el.com>
To: Binbin Zhou <zhoubinbin@...ngson.cn>,
Binbin Zhou <zhoubb.aaron@...il.com>,
Huacai Chen <chenhuacai@...ngson.cn>, Lee Jones <lee@...nel.org>,
Corey Minyard <minyard@....org>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
openipmi-developer@...ts.sourceforge.net,
dri-devel@...ts.freedesktop.org, Xuerui Wang <kernel@...0n.name>,
loongarch@...ts.linux.dev, Chong Qiao <qiaochong@...ngson.cn>
Subject: Re: [PATCH v1 2/4] ipmi: Add Loongson-2K BMC support
Hi Binbin,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.13-rc5]
[cannot apply to cminyard-ipmi/for-next lee-mfd/for-mfd-next lee-mfd/for-mfd-fixes next-20241220]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Binbin-Zhou/mfd-ls2kbmc-Introduce-Loongson-2K-BMC-MFD-Core-driver/20241230-174205
base: linus/master
patch link: https://lore.kernel.org/r/a4cfdeed1a91a7a12c7ebe56bed2ba94991c4065.1735550269.git.zhoubinbin%40loongson.cn
patch subject: [PATCH v1 2/4] ipmi: Add Loongson-2K BMC support
config: loongarch-randconfig-r123-20241231 (https://download.01.org/0day-ci/archive/20241231/202412311950.Ij7v1vKv-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.2.0
reproduce: (https://download.01.org/0day-ci/archive/20241231/202412311950.Ij7v1vKv-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412311950.Ij7v1vKv-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> drivers/char/ipmi/ipmi_si_ls2k.c:110:38: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct ls2k_kcs_data *ik @@ got void [noderef] __iomem *const addr @@
drivers/char/ipmi/ipmi_si_ls2k.c:110:38: sparse: expected struct ls2k_kcs_data *ik
drivers/char/ipmi/ipmi_si_ls2k.c:110:38: sparse: got void [noderef] __iomem *const addr
drivers/char/ipmi/ipmi_si_ls2k.c:168:38: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct ls2k_kcs_data *ik @@ got void [noderef] __iomem *const addr @@
drivers/char/ipmi/ipmi_si_ls2k.c:168:38: sparse: expected struct ls2k_kcs_data *ik
drivers/char/ipmi/ipmi_si_ls2k.c:168:38: sparse: got void [noderef] __iomem *const addr
>> drivers/char/ipmi/ipmi_si_ls2k.c:226:24: sparse: sparse: symbol 'ipmi_ls2k_platform_driver' was not declared. Should it be static?
vim +110 drivers/char/ipmi/ipmi_si_ls2k.c
106
107 static unsigned char ls2k_mem_inb(const struct si_sm_io *io,
108 unsigned int offset)
109 {
> 110 struct ls2k_kcs_data *ik = io->addr;
111 int inb = 0;
112
113 if (ik->version == 0)
114 inb = intf_sim_inb_v0(ik, offset);
115 else if (ik->version == 1)
116 inb = intf_sim_inb_v1(ik, offset);
117
118 return inb;
119 }
120
121 static void intf_sim_outb_v0(struct ls2k_kcs_data *ik, unsigned int offset,
122 unsigned char val)
123 {
124 if (ls2k_get_ibf(ik))
125 return;
126
127 switch (offset & BIT(0)) {
128 case 0:
129 ik->reg.data_in = val;
130 ik->reg.status &= ~LS2K_KCS_STS_CMD;
131 break;
132
133 case 1:
134 ik->reg.cmd = val;
135 ik->reg.status |= LS2K_KCS_STS_CMD;
136 break;
137 }
138
139 ls2k_set_ibf(ik, 1);
140 ik->write_req++;
141 }
142
143 static void intf_sim_outb_v1(struct ls2k_kcs_data *ik, unsigned int offset,
144 unsigned char val)
145 {
146 if (ik->fifo.ibfh != ik->fifo.ibft)
147 return;
148
149 switch (offset & BIT(0)) {
150 case 0:
151 ik->reg.data_in = val;
152 ik->cmd_data = 0;
153 break;
154
155 case 1:
156 ik->reg.cmd = val;
157 ik->cmd_data = 1;
158 break;
159 }
160
161 ik->fifo.ibfh = !ik->fifo.ibft;
162 ik->write_req++;
163 }
164
165 static void ls2k_mem_outb(const struct si_sm_io *io, unsigned int offset,
166 unsigned char val)
167 {
168 struct ls2k_kcs_data *ik = io->addr;
169
170 if (ik->version == 0)
171 intf_sim_outb_v0(ik, offset, val);
172 else if (ik->version == 1)
173 intf_sim_outb_v1(ik, offset, val);
174 }
175
176 static void ls2k_mem_cleanup(struct si_sm_io *io)
177 {
178 if (io->addr)
179 iounmap(io->addr);
180 }
181
182 static int ipmi_ls2k_sim_setup(struct si_sm_io *io)
183 {
184 io->addr = ioremap(io->addr_data, io->regspacing);
185 if (!io->addr)
186 return -EIO;
187
188 io->inputb = ls2k_mem_inb;
189 io->outputb = ls2k_mem_outb;
190 io->io_cleanup = ls2k_mem_cleanup;
191
192 return 0;
193 }
194
195 static int ipmi_ls2k_probe(struct platform_device *pdev)
196 {
197 struct si_sm_io io;
198
199 dev_info(&pdev->dev, "probing via ls2k platform");
200 memset(&io, 0, sizeof(io));
201
202 io.addr_source = SI_PLATFORM;
203 io.si_type = SI_KCS;
204 io.addr_space = IPMI_MEM_ADDR_SPACE;
205 io.io_setup = ipmi_ls2k_sim_setup;
206 io.addr_data = pdev->resource[0].start;
207 io.regspacing = pdev->resource[0].end - pdev->resource[0].start + 1;
208 io.regsize = DEFAULT_REGSIZE;
209 io.regshift = 0;
210 io.dev = &pdev->dev;
211 io.irq = 0;
212 if (io.irq)
213 io.irq_setup = ipmi_std_irq_setup;
214
215 dev_info(&pdev->dev, "%pR regsize %d spacing %d irq %d\n",
216 &pdev->resource[0], io.regsize, io.regspacing, io.irq);
217
218 return ipmi_si_add_smi(&io);
219 }
220
221 static void ipmi_ls2k_remove(struct platform_device *pdev)
222 {
223 ipmi_si_remove_by_dev(&pdev->dev);
224 }
225
> 226 struct platform_driver ipmi_ls2k_platform_driver = {
227 .driver = {
228 .name = "ls2k-ipmi-si",
229 },
230 .probe = ipmi_ls2k_probe,
231 .remove = ipmi_ls2k_remove,
232 };
233
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists