linux-kernel - Re: [PATCH v1 3/4] drm/ls2kbmc: Add support for Loongson-2K BMC display

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3daaaff8-062a-4985-a5bc-8d228314b02e@suse.de>
Date: Thu, 2 Jan 2025 10:07:23 +0100
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Binbin Zhou <zhoubinbin@...ngson.cn>, Binbin Zhou
 <zhoubb.aaron@...il.com>, Huacai Chen <chenhuacai@...ngson.cn>,
 Lee Jones <lee@...nel.org>, Corey Minyard <minyard@....org>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>
Cc: Huacai Chen <chenhuacai@...nel.org>, linux-kernel@...r.kernel.org,
 openipmi-developer@...ts.sourceforge.net, dri-devel@...ts.freedesktop.org,
 Xuerui Wang <kernel@...0n.name>, loongarch@...ts.linux.dev,
 Chong Qiao <qiaochong@...ngson.cn>
Subject: Re: [PATCH v1 3/4] drm/ls2kbmc: Add support for Loongson-2K BMC
 display

Hi


Am 30.12.24 um 10:31 schrieb Binbin Zhou:
[...]
> +
> +static struct platform_driver ls2kbmc_platform_driver = {
> +	.driver = {
> +		.name = "ls2kbmc-framebuffer",

The driver is mostly a copy of simpledrm. Why don't you use 
"simple-framebuffer" for your device name? You could use simpledrm 
directly then.

Best regards
Thomas

> +	},
> +	.probe = ls2kbmc_probe,
> +	.remove = ls2kbmc_remove,
> +};
> +
> +module_platform_driver(ls2kbmc_platform_driver);
> +
> +MODULE_DESCRIPTION("DRM driver for Loongson-2K BMC");
> +MODULE_LICENSE("GPL");

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)