linux-kernel - Re: [PATCH v4 03/11] mtd: intel-dg: implement region enumeration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <022418c7-f2b2-47b7-9b61-da3f4b7dffab@wanadoo.fr>
Date: Thu, 2 Jan 2025 11:37:43 +0100
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Alexander Usyskin <alexander.usyskin@...el.com>,
 Miquel Raynal <miquel.raynal@...tlin.com>,
 Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>,
 Lucas De Marchi <lucas.demarchi@...el.com>,
 Thomas Hellström <thomas.hellstrom@...ux.intel.com>,
 Rodrigo Vivi <rodrigo.vivi@...el.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Jani Nikula <jani.nikula@...ux.intel.com>,
 Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
 Tvrtko Ursulin <tursulin@...ulin.net>,
 Karthik Poosa <karthik.poosa@...el.com>
Cc: Reuven Abliyev <reuven.abliyev@...el.com>,
 Oren Weil <oren.jer.weil@...el.com>, linux-mtd@...ts.infradead.org,
 dri-devel@...ts.freedesktop.org, intel-gfx@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, Tomas Winkler <tomasw@...il.com>
Subject: Re: [PATCH v4 03/11] mtd: intel-dg: implement region enumeration

Le 01/01/2025 à 16:39, Alexander Usyskin a écrit :
> In intel-dg, there is no access to the spi controller,
> the information is extracted from the descriptor region.
> 
> CC: Lucas De Marchi <lucas.demarchi@...el.com>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@...el.com>
> Acked-by: Miquel Raynal <miquel.raynal@...tlin.com>
> Co-developed-by: Tomas Winkler <tomasw@...il.com>
> Signed-off-by: Tomas Winkler <tomasw@...il.com>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@...el.com>

...

> @@ -89,6 +281,13 @@ static int intel_dg_mtd_probe(struct auxiliary_device *aux_dev,
>   		goto err;
>   	}
>   
> +	ret = intel_dg_nvm_init(nvm, device);
> +	if (ret < 0) {
> +		dev_err(device, "cannot initialize nvm\n");
> +		ret = -ENODEV;

Why setting to -ENODEV?

> +		goto err;
> +	}
> +
>   	dev_set_drvdata(&aux_dev->dev, nvm);
>   
>   	return 0;