linux-kernel - RE: [PATCH v4 03/11] mtd: intel-dg: implement region enumeration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY5PR11MB63669457E0CEF348A97324F7ED142@CY5PR11MB6366.namprd11.prod.outlook.com>
Date: Thu, 2 Jan 2025 10:49:27 +0000
From: "Usyskin, Alexander" <alexander.usyskin@...el.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>, Miquel Raynal
	<miquel.raynal@...tlin.com>, Richard Weinberger <richard@....at>, "Vignesh
 Raghavendra" <vigneshr@...com>, "De Marchi, Lucas"
	<lucas.demarchi@...el.com>, Thomas Hellström
	<thomas.hellstrom@...ux.intel.com>, "Vivi, Rodrigo" <rodrigo.vivi@...el.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
	<mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, David Airlie
	<airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Jani Nikula
	<jani.nikula@...ux.intel.com>, Joonas Lahtinen
	<joonas.lahtinen@...ux.intel.com>, Tvrtko Ursulin <tursulin@...ulin.net>,
	"Poosa, Karthik" <karthik.poosa@...el.com>
CC: "Abliyev, Reuven" <reuven.abliyev@...el.com>, "Weil, Oren jer"
	<oren.jer.weil@...el.com>, "linux-mtd@...ts.infradead.org"
	<linux-mtd@...ts.infradead.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "intel-gfx@...ts.freedesktop.org"
	<intel-gfx@...ts.freedesktop.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Tomas Winkler <tomasw@...il.com>
Subject: RE: [PATCH v4 03/11] mtd: intel-dg: implement region enumeration

> 
> > @@ -89,6 +281,13 @@ static int intel_dg_mtd_probe(struct
> auxiliary_device *aux_dev,
> >   		goto err;
> >   	}
> >
> > +	ret = intel_dg_nvm_init(nvm, device);
> > +	if (ret < 0) {
> > +		dev_err(device, "cannot initialize nvm\n");
> > +		ret = -ENODEV;
> 
> Why setting to -ENODEV?
> 

You are right, for ret < 0 we can keep error code.
Will fix in the next revision.

- - 
Thanks,
Sasha



> > +		goto err;
> > +	}
> > +
> >   	dev_set_drvdata(&aux_dev->dev, nvm);
> >
> >   	return 0;