linux-kernel - Re: [PATCH 14/14] scripts/sorttable: ftrace: Do not add weak functions to available_filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250102145501.3e821c56@gandalf.local.home>
Date: Thu, 2 Jan 2025 14:55:01 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Peter Zijlstra <peterz@...radead.org>
Cc: linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 linux-kbuild@...r.kernel.org, bpf <bpf@...r.kernel.org>, Masami Hiramatsu
 <mhiramat@...nel.org>, Mark Rutland <mark.rutland@....com>, Mathieu
 Desnoyers <mathieu.desnoyers@...icios.com>, Andrew Morton
 <akpm@...ux-foundation.org>, Linus Torvalds
 <torvalds@...ux-foundation.org>, Masahiro Yamada <masahiroy@...nel.org>,
 Nathan Chancellor <nathan@...nel.org>, Nicolas Schier <nicolas@...sle.eu>,
 Zheng Yejian <zhengyejian1@...wei.com>, Martin Kelly
 <martin.kelly@...wdstrike.com>, Christophe Leroy
 <christophe.leroy@...roup.eu>, Josh Poimboeuf <jpoimboe@...hat.com>
Subject: Re: [PATCH 14/14] scripts/sorttable: ftrace: Do not add weak
 functions to available_filter_functions

On Thu, 2 Jan 2025 20:48:14 +0100
Peter Zijlstra <peterz@...radead.org> wrote:

> *sigh*.. can we please just either add the 'hole' symbols in symtab, or
> fix symtab to have entry size?
> 
> You're just fixing your one problem and leaving everybody else that has
> extra data inside the dead weak things up a creek :/
> 
> Eg. if might make sense to also ignore alternative / static_branch /
> static_call patching for such 'dead' code. Yes, that's not an immediate
> problem atm, but just fixing __mcount_loc seems very short sighted.

Read my reply to the email that I forgot to add to the cover letter (but
mention in the last patch). Fixing kallsyms does not remove the place
holders in the available_filter_functions. This has nothing to do with
kallsyms. I need to remove the fentry/mcount references in the mcount_loc
section.

The kallsyms is a completely different issue.

-- Steve