linux-kernel - Re: [PATCH] filemap: avoid truncating 64-bit offset to 32 bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250102232536.GW6174@frogsfrogsfrogs>
Date: Thu, 2 Jan 2025 15:25:36 -0800
From: "Darrick J. Wong" <djwong@...nel.org>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Marco Nelissen <marco.nelissen@...il.com>,
	"Matthew Wilcox (Oracle)" <willy@...radead.org>,
	linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, linux-xfs@...r.kernel.org
Subject: Re: [PATCH] filemap: avoid truncating 64-bit offset to 32 bits

On Thu, Jan 02, 2025 at 02:10:15PM -0800, Andrew Morton wrote:
> On Thu,  2 Jan 2025 11:04:11 -0800 Marco Nelissen <marco.nelissen@...il.com> wrote:
> 
> > on 32-bit kernels, folio_seek_hole_data() was inadvertently truncating a
> > 64-bit value to 32 bits, leading to a possible infinite loop when writing
> > to an xfs filesystem.
> > 
> > ...
> >
> > +++ b/mm/filemap.c
> > @@ -3005,7 +3005,7 @@ static inline loff_t folio_seek_hole_data(struct xa_state *xas,
> >  		if (ops->is_partially_uptodate(folio, offset, bsz) ==
> >  							seek_data)
> >  			break;
> > -		start = (start + bsz) & ~(bsz - 1);
> > +		start = (start + bsz) & ~((u64)bsz - 1);
> >  		offset += bsz;
> >  	} while (offset < folio_size(folio));
> >  unlock:
> 
> Thanks.  I'll add
> 
> Fixes: 54fa39ac2e00b ("iomap: use mapping_seek_hole_data")
> Cc: <stable@...r.kernel.org>
> 
> The
> 
> 	offset = offset_in_folio(folio, start) & ~(bsz - 1);
> 
> a few lines earlier is worrisome.  I wonder if we should simply make
> `bsz' and `offset' have type u64 and sleep well at night.

I think that callsite is ok because offset_in_folio() should never
return a value larger than 2^31 ... right?  IOWs, only the second case
needs casting because @start is loff_t.

--D