linux-kernel - Re: [PATCH] x86/mm: Fix flush_tlb_range() when used for zapping normal PMDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a1fff596435121b01766bed27e401e8a27bf8f92.camel@surriel.com>
Date: Fri, 03 Jan 2025 16:55:25 -0500
From: Rik van Riel <riel@...riel.com>
To: Jann Horn <jannh@...gle.com>, Dave Hansen <dave.hansen@...ux.intel.com>,
  Andy Lutomirski	 <luto@...nel.org>, Peter Zijlstra <peterz@...radead.org>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] x86/mm: Fix flush_tlb_range() when used for zapping
 normal PMDs

On Fri, 2025-01-03 at 19:39 +0100, Jann Horn wrote:
> 02fc2aa06e9e0ecdba3fe948cafe5892b72e86c0..3da645139748538daac70166618d
> 8ad95116eb74 100644
> --- a/arch/x86/include/asm/tlbflush.h
> +++ b/arch/x86/include/asm/tlbflush.h
> @@ -242,7 +242,7 @@ void flush_tlb_multi(const struct cpumask
> *cpumask,
>  	flush_tlb_mm_range((vma)->vm_mm, start,
> end,			\
>  			   ((vma)->vm_flags &
> VM_HUGETLB)		\
>  				?
> huge_page_shift(hstate_vma(vma))	\
> -				: PAGE_SHIFT, false)
> +				: PAGE_SHIFT, true)
>  
> 

The code looks good, but should this macro get
a comment indicating that code that only frees
pages, but not page tables, should be calling
flush_tlb() instead?

-- 
All Rights Reversed.