linux-kernel - Re: [PATCH v5 2/5] phy: qcom: Introduce PCIe UNIPHY 28LP driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <twxesiftakrmxh2k433ws5sb6mdaj7po7m5b2aca4rvprt2ot4@rghove4l6ldn>
Date: Fri, 3 Jan 2025 08:43:41 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Varadarajan Narayanan <quic_varada@...cinc.com>, bhelgaas@...gle.com, 
	lpieralisi@...nel.org, kw@...ux.com, manivannan.sadhasivam@...aro.org, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, vkoul@...nel.org, kishon@...nel.org, 
	andersson@...nel.org, konradybcio@...nel.org, p.zabel@...gutronix.de, 
	quic_nsekar@...cinc.com, linux-arm-msm@...r.kernel.org, linux-pci@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org
Subject: Re: [PATCH v5 2/5] phy: qcom: Introduce PCIe UNIPHY 28LP driver

On Fri, Jan 03, 2025 at 07:48:10AM +0200, Dmitry Baryshkov wrote:
> > +	platform_set_drvdata(pdev, phy);
> > +	phy->dev = &pdev->dev;
> > +
> > +	phy->data = of_device_get_match_data(dev);
> > +	if (!phy->data)
> > +		return -EINVAL;
> > +
> > +	ret = of_property_read_u32(of_node_get(dev->of_node), "num-lanes",
> 
> Who will put the reference count which you have just got?

More important: why introducing own pattern of code...

Best regards,
Krzysztof