linux-kernel - RE: [PATCH] wifi: rtw88: 8703b: Fix RX/TX issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f69874f3c11f4c7b8b0e3026796bb452@realtek.com>
Date: Fri, 3 Jan 2025 09:12:59 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Vasily Khoruzhick <anarsoul@...il.com>, Kalle Valo <kvalo@...nel.org>,
        Fiona Klute <fiona.klute@....de>,
        Bitterblue Smith <rtl8821cerfe2@...il.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH] wifi: rtw88: 8703b: Fix RX/TX issues

Vasily Khoruzhick <anarsoul@...il.com> wrote:
> Fix 3 typos in 8703b driver. 2 typos in calibration routines are not
> fatal and do not seem to have any impact, just fix them to match vendor
> driver.

Just curious how you can find these typos? 

> 
> However the last one in rtw8703b_set_channel_bb() clears too many bits
> in REG_OFDM0_TX_PSD_NOISE, causing TX and RX issues (neither rate goes
> above MCS0-MCS1). Vendor driver clears only 2 most significant bits.
> 
> With the last typo fixed, the driver is able to reach MCS7 on Pinebook
> 
> Cc: stable@...r.kernel.org
> Fixes: 9bb762b3a957 ("wifi: rtw88: Add definitions for 8703b chip")
> Signed-off-by: Vasily Khoruzhick <anarsoul@...il.com>

Acked-by: Ping-Ke Shih <pkshih@...ltek.com>

Is this urgent? If not, I will take this via rtw-next tree.