linux-kernel - Re: [PATCH] wifi: rtw88: 8703b: Fix RX/TX issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6f4d483-6f05-4221-8412-5c245e5974b4@gmx.de>
Date: Fri, 3 Jan 2025 13:55:54 +0200
From: Fiona Klute <fiona.klute@....de>
To: Ping-Ke Shih <pkshih@...ltek.com>, Vasily Khoruzhick
 <anarsoul@...il.com>, Kalle Valo <kvalo@...nel.org>,
 Bitterblue Smith <rtl8821cerfe2@...il.com>,
 "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc: "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH] wifi: rtw88: 8703b: Fix RX/TX issues

Am 03.01.25 um 11:12 schrieb Ping-Ke Shih:
> Vasily Khoruzhick <anarsoul@...il.com> wrote:
>> Fix 3 typos in 8703b driver. 2 typos in calibration routines are not
>> fatal and do not seem to have any impact, just fix them to match vendor
>> driver.
>
> Just curious how you can find these typos?
>
>>
>> However the last one in rtw8703b_set_channel_bb() clears too many bits
>> in REG_OFDM0_TX_PSD_NOISE, causing TX and RX issues (neither rate goes
>> above MCS0-MCS1). Vendor driver clears only 2 most significant bits.
>>
>> With the last typo fixed, the driver is able to reach MCS7 on Pinebook
>>
>> Cc: stable@...r.kernel.org
>> Fixes: 9bb762b3a957 ("wifi: rtw88: Add definitions for 8703b chip")
>> Signed-off-by: Vasily Khoruzhick <anarsoul@...il.com>
>
> Acked-by: Ping-Ke Shih <pkshih@...ltek.com>
>
> Is this urgent? If not, I will take this via rtw-next tree.
It's a huge performance improvement, 10x more RX throughput in Iperf
tests, not just in the reported bit rate (residential, moderately noisy
environment). TX improved too, but not as massively.

Tested-by: Fiona Klute <fiona.klute@....de>

Thank you very much Vasily for digging into this!

Best regards,
Fiona