linux-kernel - Re: [PATCH 1/2] Input: goodix-berlin - fix comment referencing wrong regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7dd25309-cf51-4e5e-8ddd-24267670ecf2@linaro.org>
Date: Fri, 3 Jan 2025 10:26:13 +0100
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Luca Weiss <luca.weiss@...rphone.com>, Bastien Nocera
 <hadess@...ess.net>, Hans de Goede <hdegoede@...hat.com>,
 Dmitry Torokhov <dmitry.torokhov@...il.com>, Jeff LaBundy
 <jeff@...undy.com>, Charles Wang <charles.goodix@...il.com>,
 Jens Reidel <adrian@...vitia.xyz>
Cc: ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
 linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Input: goodix-berlin - fix comment referencing wrong
 regulator

On 03/01/2025 10:21, Luca Weiss wrote:
> In the statement above AVDD gets enabled, and not IOVDD, so fix this
> copy-paste mistake.
> 
> Fixes: 44362279bdd4 ("Input: add core support for Goodix Berlin Touchscreen IC")
> Reported-by: Jens Reidel <adrian@...vitia.xyz>
> Signed-off-by: Luca Weiss <luca.weiss@...rphone.com>
> ---
>   drivers/input/touchscreen/goodix_berlin_core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/goodix_berlin_core.c b/drivers/input/touchscreen/goodix_berlin_core.c
> index 3fc03cf0ca23fdbe36028a6228030d3ffb8d3a09..e273fb8edc6b92bcbad0fd35223a841d7da7d671 100644
> --- a/drivers/input/touchscreen/goodix_berlin_core.c
> +++ b/drivers/input/touchscreen/goodix_berlin_core.c
> @@ -263,7 +263,7 @@ static int goodix_berlin_power_on(struct goodix_berlin_core *cd)
>   		goto err_iovdd_disable;
>   	}
>   
> -	/* Vendor waits 15ms for IOVDD to settle */
> +	/* Vendor waits 15ms for AVDD to settle */
>   	usleep_range(15000, 15100);
>   
>   	gpiod_set_value_cansleep(cd->reset_gpio, 0);
> 

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>