linux-kernel - Re: [PATCH v10 03/10] drm/connector: implement generic HDMI audio helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x73a2utr5sp4iffk5626zqfth4ayu3x4jkxd7xwjti7ehrgnzi@ploxx4i5db5h>
Date: Fri, 3 Jan 2025 14:37:03 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc: Laurent.pinchart@...asonboard.com, airlied@...il.com, 
	alain.volmat@...s.st.com, alim.akhtar@...sung.com, andrzej.hajda@...el.com, 
	andy.yan@...k-chips.com, angelogioacchino.delregno@...labora.com, broonie@...nel.org, 
	chunkuang.hu@...nel.org, dave.stevenson@...pberrypi.com, dri-devel@...ts.freedesktop.org, 
	heiko@...ech.de, hjc@...k-chips.com, inki.dae@...sung.com, 
	jani.nikula@...ux.intel.com, jernej.skrabec@...il.com, jonas@...boo.se, 
	kernel-list@...pberrypi.com, krzk@...nel.org, kyungmin.park@...sung.com, lgirdwood@...il.com, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org, 
	linux-rockchip@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, linux-sound@...r.kernel.org, 
	linux@...linux.org.uk, maarten.lankhorst@...ux.intel.com, matthias.bgg@...il.com, 
	mcanal@...lia.com, mripard@...nel.org, neil.armstrong@...aro.org, 
	p.zabel@...gutronix.de, perex@...ex.cz, ple@...libre.com, rfoss@...nel.org, 
	rgallaispou@...il.com, simona@...ll.ch, sw0312.kim@...sung.com, tiwai@...e.com, 
	tzimmermann@...e.de
Subject: Re: [PATCH v10 03/10] drm/connector: implement generic HDMI audio
 helpers

On Tue, Dec 31, 2024 at 07:49:40PM +0100, Martin Blumenstingl wrote:
> On Tue, Dec 31, 2024 at 3:34 AM Dmitry Baryshkov
> <dmitry.baryshkov@...aro.org> wrote:
> [...]
> > > I checked all instances of struct hdmi_codec_ops in v6.13-rc3 and it
> > > seems that there is only a single driver which uses the .prepare
> > > callback (drivers/gpu/drm/vc4/vc4_hdmi.c). All other drivers seem to
> > > implement .hw_params instead.
> >
> > Yes. However .hw_params don't have access to the infoframe contents, so
> > I had to settle on implementing .prepare.
> While debugging I noticed something unrelated to my problem:
> hdmi_codec_spdif_dai_ops does not implement .prepare().
> FYI just in case someone wants to use your patches and feed the
> hdmi-codec with SPDIF instead of I2S.

Could you please send submit a patch to the hdmi-codec driver?

-- 
With best wishes
Dmitry