linux-kernel - Re: [PATCH can-next v3 0/3] can: tcan4x5x/m_can: use standby mode when down and in suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <xn36paqpsjld52s7tkpanyu5v5626vz6bglu76xe225a2y64fh@mz4jvy7avkeh>
Date: Fri, 3 Jan 2025 13:37:19 +0100
From: Sean Nyekjaer <sean@...nix.com>
To: Chandrasekar Ramakrishnan <rcsekar@...sung.com>, 
	Marc Kleine-Budde <mkl@...gutronix.de>, Vincent Mailhol <mailhol.vincent@...adoo.fr>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: linux-can@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH can-next v3 0/3] can: tcan4x5x/m_can: use standby mode
 when down and in suspend

On Fri, Nov 22, 2024 at 03:52:21PM +0100, Sean Nyekjaer wrote:
> When downing the tcan4x5x there is no reason to keep the tcan4x5x in
> "normal" mode and waste power.
> So set standby mode when the interface is down and normal mode when
> interface is up.
> 
> Also when going into suspend, set the tcan4x5x into standby mode. The
> tcan4x5x can still be used as a wake-source when in standby as low power
> rx is enabled.
> 
> Signed-off-by: Sean Nyekjaer <sean@...nix.com>
> ---
> Changes in v3:
> - Run deinit in m_can_stop() in any case even if m_can_cccr_update_bits() fails
> - Link to v2: https://lore.kernel.org/r/20241115-tcan-standby-v2-0-4eb02026b237@geanix.com
> 
> Changes in v2:
> - Reduced code in tcan4x5x_deinit()
> - Taken care of return values from deinit callback
> - Link to v1: https://lore.kernel.org/r/20241111-tcan-standby-v1-0-f9337ebaceea@geanix.com
> 
> ---

Hi,

Anything needed from my side on this?

/Sean