linux-kernel - Re: [PATCH 1/3] dt-bindings: clock: Add bindings for Canaan K230 clock controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a097980a-c2b7-440c-8eff-b540acfd4027@kernel.org>
Date: Sat, 4 Jan 2025 11:40:31 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Xukai Wang <kingxukai@...omail.com>
Cc: Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Paul Walmsley <paul.walmsley@...ive.com>,
 Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
 Troy Mitchell <TroyMitchell988@...il.com>
Subject: Re: [PATCH 1/3] dt-bindings: clock: Add bindings for Canaan K230
 clock controller

On 04/01/2025 10:23, Xukai Wang wrote:
> 
> Here's the update version:
> 
> reg:
>   description: |
>     The `reg` property specifies the base address and size of the
> device's registers.
>     - The first address corresponds to the base address of the PLL
> control registers.
>     - The second address corresponds to the base address of the sysclk
> control registers.

No, drop all these. You duplicate schema.

>   minItems: 1

Why?

>   items:
>     - description: Base address and size of the PLL control registers.
>     - description: Base address and size of the sysclk control registers.

Drop redundant "Base address and size of the". This cannot be anything
else in this context.

> 
> Does this content look appropriate?
> 
>>> +
>>> +  '#clock-cells':
>>> +    const: 1
>>> +
>>> +required:
>>> +  - compatible
>>> +  - reg
>>> +  - clocks
>>> +  - '#clock-cells'
>>> +
>>> +additionalProperties: false
>>> +
>>> +examples:
>>> +  - |
>>> +    clock-controller@...02000 {
>>> +        compatible = "canaan,k230-clk";
>>> +        reg = <0x91102000 0x1000>, <0x91100000 0x1000>;
>>> +        #clock-cells = <1>;
>>> +        clocks = <&osc24m>;
>>> +    };
>>> diff --git a/include/dt-bindings/clock/k230-clk.h b/include/dt-bindings/clock/k230-clk.h

I missed one thing - filename is supposed to be the same as binding
filename.

Best regards,
Krzysztof