linux-kernel - Re: [PATCH V10 RESEND] EDAC: Add EDAC driver for loongson memory controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250104104705.GAZ3kRqVra2JaQPn8h@fat_crate.local>
Date: Sat, 4 Jan 2025 11:47:05 +0100
From: Borislav Petkov <bp@...en8.de>
To: Zhao Qunqin <zhaoqunqin@...ngson.cn>
Cc: chenhuacai@...nel.org, linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel@...0n.name,
	tony.luck@...el.com, james.morse@....com, mchehab@...nel.org,
	rric@...nel.org, loongarch@...ts.linux.dev, xry111@...111.site,
	Markus.Elfring@....de, Jonathan.Cameron@...wei.com,
	Huacai Chen <chenhuacai@...ngson.cn>
Subject: Re: [PATCH V10 RESEND] EDAC: Add EDAC driver for loongson memory
 controller

On Sat, Jan 04, 2025 at 11:31:00AM +0100, Borislav Petkov wrote:
> > That ECC register can not be zeroed.
> 
> Pfff, that's some weird hardware you have there. Oh well. Lemme take a look at
> your patch.

diff --git a/drivers/edac/loongson_edac.c b/drivers/edac/loongson_edac.c
index e267b526b52f..38745800ed01 100644
--- a/drivers/edac/loongson_edac.c
+++ b/drivers/edac/loongson_edac.c
@@ -15,6 +15,13 @@
 
 struct loongson_edac_pvt {
 	void __iomem *ecc_base;
+
+	/*
+	 * The ECC register in this controller records the number of errors
+	 * encountered since reset and cannot be zeroed so in order to be able
+	 * to report the error count at each check, this records the previous
+	 * register state.
+	 */
 	int last_ce_count;
 };


-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette