linux-kernel - Re: [PATCH v15 01/13] x86/sev: Carve out and export SNP guest messaging init routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c49a713c6c13fc0faef039ab5ef6b38090c20f6.camel@gmail.com>
Date: Sat, 04 Jan 2025 20:06:14 +0100
From: Francesco Lavra <francescolavra.fl@...il.com>
To: nikunj@....com
Cc: bp@...en8.de, dave.hansen@...ux.intel.com, kvm@...r.kernel.org, 
 linux-kernel@...r.kernel.org, mingo@...hat.com, pbonzini@...hat.com, 
 pgonda@...gle.com, seanjc@...gle.com, tglx@...utronix.de,
 thomas.lendacky@....com,  x86@...nel.org
Subject: Re: [PATCH v15 01/13] x86/sev: Carve out and export SNP guest
 messaging init routines

On 2024-12-03 at 9:00, Nikunj A Dadhania wrote:

> diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c
> index c5b0148b8c0a..3cc741eefd06 100644
> --- a/arch/x86/coco/sev/core.c
> +++ b/arch/x86/coco/sev/core.c
...
> +void snp_msg_free(struct snp_msg_desc *mdesc)
> +{
> +	if (!mdesc)
> +		return;
> +
> +	mdesc->vmpck = NULL;
> +	mdesc->os_area_msg_seqno = NULL;
> +	kfree(mdesc->ctx);
> +
> +	free_shared_pages(mdesc->response, sizeof(struct
> snp_guest_msg));
> +	free_shared_pages(mdesc->request, sizeof(struct
> snp_guest_msg));
> +	iounmap((__force void __iomem *)mdesc->secrets);
> +	kfree(mdesc);

This is leaking mdesc->certs_data.