linux-kernel - Re: [PATCH] security: remove redundant assignment to variable rc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e9b49e3e80d71ab8a34f7d873614908@paul-moore.com>
Date: Sat, 04 Jan 2025 21:52:12 -0500
From: Paul Moore <paul@...l-moore.com>
To: Colin Ian King <colin.i.king@...il.com>, James Morris <jmorris@...ei.org>, "Serge E . Hallyn" <serge@...lyn.com>, linux-security-module@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] security: remove redundant assignment to variable rc

On Nov 12, 2024 Colin Ian King <colin.i.king@...il.com> wrote:
> 
> In the case where rc is equal to EOPNOTSUPP it is being reassigned a
> new value of zero that is never read. The following continue statement
> loops back to the next iteration of the lsm_for_each_hook loop and
> rc is being re-assigned a new value from the call to getselfattr.
> The assignment is redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> Reviewed-by: Serge Hallyn <serge@...lyn.com>
> ---
>  security/security.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Merged to lsm/dev, thanks.

--
paul-moore.com