linux-kernel - Re: [PATCH][next] security: remove redundant assignment to variable rc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhQuVYCNZm9S-TsJ7vm-Zihp=A5qHXQ8BPyZcfncakvOfA@mail.gmail.com>
Date: Sat, 4 Jan 2025 21:54:30 -0500
From: Paul Moore <paul@...l-moore.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: "Serge E. Hallyn" <serge@...lyn.com>, Colin Ian King <colin.i.king@...il.com>, 
	James Morris <jmorris@...ei.org>, linux-security-module@...r.kernel.org, 
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] security: remove redundant assignment to variable rc

On Tue, Nov 12, 2024 at 9:00 AM Dan Carpenter <dan.carpenter@...aro.org> wrote:
> On Tue, Nov 12, 2024 at 07:32:24AM -0600, Serge E. Hallyn wrote:
> > On Tue, Nov 12, 2024 at 12:45:32PM +0000, Colin Ian King wrote:
> > > In the case where rc is equal to EOPNOTSUPP it is being reassigned a
> > > new value of zero that is never read. The following continue statement
> > > loops back to the next iteration of the lsm_for_each_hook loop and
> > > rc is being re-assigned a new value from the call to getselfattr.
> > > The assignment is redundant and can be removed.
> > >
> > > Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> >
> > Reviewed-by: Serge Hallyn <serge@...lyn.com>
> >
> > (long as it doesn't go to stable :)
> >
>
> There is a tag for fixes which would break stable.
>
> Cc: <stable+noautosel@...nel.org> # reason goes here, and must be present
>
> But this isn't a fix and it wouldn't break stable so probably that's not
> appropriate.

I've also talked with the stable kernel folks and they no longer
automatically pull any LSM commits with a 'Fixes:' tag.  LSM commits
need to be explicitly marked with the stable CC for them to be pulled
into the stable trees.

-- 
paul-moore.com