linux-kernel - Re: [PATCH v9 1/4] clk: qcom: gdsc: Release pm subdomains in reverse add order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3nq6zehelawkkdsxuod32pyntxdgbijsjm5bwk5hu6l3nni7lo@5aeutzvdefku>
Date: Mon, 6 Jan 2025 10:53:15 -0600
From: Bjorn Andersson <andersson@...nel.org>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Cc: Michael Turquette <mturquette@...libre.com>, 
	Stephen Boyd <sboyd@...nel.org>, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, 
	Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>, Rajendra Nayak <quic_rjendra@...cinc.com>, 
	linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, 
	stable@...r.kernel.org
Subject: Re: [PATCH v9 1/4] clk: qcom: gdsc: Release pm subdomains in reverse
 add order

On Mon, Dec 30, 2024 at 01:30:18PM +0000, Bryan O'Donoghue wrote:
> gdsc_unregister() should release subdomains in the reverse order to the
> order in which those subdomains were added.
> 

This sounds very reasonable to me, but what's the actual reason?

> Fixes: 1b771839de05 ("clk: qcom: gdsc: enable optional power domain support")
> Cc: stable@...r.kernel.org

Without a reason it's hard to see why this needs to be backported.

Regards,
Bjorn

> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> ---
>  drivers/clk/qcom/gdsc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/qcom/gdsc.c b/drivers/clk/qcom/gdsc.c
> index fa5fe4c2a2ee7786c2e8858f3e41301f639e5d59..bc1b1e37bf4222017c172b77603f8dedba961ed5 100644
> --- a/drivers/clk/qcom/gdsc.c
> +++ b/drivers/clk/qcom/gdsc.c
> @@ -571,7 +571,7 @@ void gdsc_unregister(struct gdsc_desc *desc)
>  	size_t num = desc->num;
>  
>  	/* Remove subdomains */
> -	for (i = 0; i < num; i++) {
> +	for (i = num - 1; i >= 0; i--) {
>  		if (!scs[i])
>  			continue;
>  		if (scs[i]->parent)
> 
> -- 
> 2.45.2
>