linux-kernel - Re: [PATCH] afs: Merge preference rule failure condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <291912.1736171315@warthog.procyon.org.uk>
Date: Mon, 06 Jan 2025 13:48:35 +0000
From: David Howells <dhowells@...hat.com>
To: Lizhi Xu <lizhi.xu@...driver.com>
Cc: dhowells@...hat.com,
    syzbot+76f33569875eb708e575@...kaller.appspotmail.com,
    linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org,
    marc.dionne@...istor.com, syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH] afs: Merge preference rule failure condition

Lizhi Xu <lizhi.xu@...driver.com> wrote:

>  		argc = afs_split_string(&buf, argv, ARRAY_SIZE(argv));
> -		if (argc < 0)
> -			return argc;
>  		if (argc < 2)
>  			goto inval;

I think this needs to be slightly different.  afs_split_string() will print
error messages and can return an error code, so we should go with that and set
ret to argc and go to done, not inval.

David