linux-kernel - Re: [PATCH 2/2] afs: Make /afs/@...l and /afs/.@...l symlinks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <576579.1736264217@warthog.procyon.org.uk>
Date: Tue, 07 Jan 2025 15:36:57 +0000
From: David Howells <dhowells@...hat.com>
To: Al Viro <viro@...iv.linux.org.uk>
Cc: dhowells@...hat.com, Marc Dionne <marc.dionne@...istor.com>,
    Christian Brauner <christian@...uner.io>,
    linux-afs@...ts.infradead.org, linux-fsdevel@...r.kernel.org,
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] afs: Make /afs/@...l and /afs/.@...l symlinks

Al Viro <viro@...iv.linux.org.uk> wrote:

> > +	dsymlink = lookup_one_len(afs_dotatcell, root, sizeof(afs_dotatcell) - 1);
> > +	if (IS_ERR(dsymlink)) {
> > +		ret = PTR_ERR(dsymlink);
> > +		dput(symlink);
> > +		goto unlock;
> > +	}
> 
> Just allocate those child dentries and call your afs_lookup_atcell() for them.
> No need to keep that mess in ->lookup() - you are keeping those suckers cached
> now, so...

Good point.  I need to do that for the cell mountpoints because someone can
arbitrarily create one by triggering a lookup of /afs/<cell>/, but for this
pair of symlinks, they're created before the sb goes live.

David