linux-kernel - Re: [PATCH 2/2] afs: Make /afs/@...l and /afs/.@...l symlinks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <599881.1736272608@warthog.procyon.org.uk>
Date: Tue, 07 Jan 2025 17:56:48 +0000
From: David Howells <dhowells@...hat.com>
To: Al Viro <viro@...iv.linux.org.uk>
Cc: dhowells@...hat.com, Marc Dionne <marc.dionne@...istor.com>,
    Christian Brauner <christian@...uner.io>,
    linux-afs@...ts.infradead.org, linux-fsdevel@...r.kernel.org,
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] afs: Make /afs/@...l and /afs/.@...l symlinks

Al Viro <viro@...iv.linux.org.uk> wrote:

> Just allocate those child dentries and call your afs_lookup_atcell() for them.
> No need to keep that mess in ->lookup() - you are keeping those suckers cached
> now, so...

Actually, I wonder if creating the inodes and dentries for cells and the @cell
symlinks at mount of the dynamic root or when the cells are created is
actually the best way.

It might be better to list all the cells and symlinks in readdir and only
create them on demand in ->lookup().  The cells are kept in their own list on
the network namespace anyway, even if the dynamic root isn't mounted.

David