linux-kernel - Re: [PATCH v2 0/6] module: sysfs: Cleanups and preparation for const struct bin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025010737-dwelling-pacific-f74f@gregkh>
Date: Tue, 7 Jan 2025 17:52:49 +0100
From: Greg KH <greg@...ah.com>
To: Petr Pavlu <petr.pavlu@...e.com>
Cc: Thomas Weißschuh <linux@...ssschuh.net>,
	Luis Chamberlain <mcgrof@...nel.org>,
	Sami Tolvanen <samitolvanen@...gle.com>,
	Daniel Gomez <da.gomez@...sung.com>, Kees Cook <kees@...nel.org>,
	"Gustavo A. R. Silva" <gustavoars@...nel.org>,
	linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2 0/6] module: sysfs: Cleanups and preparation for const
 struct bin_attribute

On Tue, Dec 31, 2024 at 04:07:40PM +0100, Petr Pavlu wrote:
> On 12/27/24 14:23, Thomas Weißschuh wrote:
> > The sysfs core is switching to 'const struct bin_attribute's.
> > Prepare for that.
> > 
> > Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> > ---
> > Changes in v2:
> > - Avoid NULL-deref in free_sect_attrs()
> > - Avoid double-free and NULL-deref in free_notes_attrs()
> > - Also drop 'struct module_sect_attr'
> > - Link to v1: https://lore.kernel.org/r/20241216-sysfs-const-bin_attr-module-v1-0-f81e49e54ce4@weissschuh.net
> > 
> > ---
> > Thomas Weißschuh (6):
> >       module: sysfs: Drop member 'module_sect_attrs::nsections'
> >       module: sysfs: Drop member 'module_sect_attr::address'
> >       module: sysfs: Drop 'struct module_sect_attr'
> >       module: sysfs: Simplify section attribute allocation
> >       module: sysfs: Add notes attributes through attribute_group
> >       module: sysfs: Use const 'struct bin_attribute'
> > 
> >  kernel/module/sysfs.c | 116 ++++++++++++++++++++++++--------------------------
> >  1 file changed, 55 insertions(+), 61 deletions(-)
> > ---
> > base-commit: d6ef8b40d075c425f548002d2f35ae3f06e9cf96
> > change-id: 20241215-sysfs-const-bin_attr-module-be05346937a6
> 
> Reviewed-by: Petr Pavlu <petr.pavlu@...e.com>
> 
> I'm going to wait for a few days if others want to comment and then plan
> to queue this on the modules tree for the 6.14 merge window.

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>