linux-kernel - Re: [PATCH v3 1/7] Input: matrix_keypad - use fsleep for variable delay duration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3134353b-1bbe-4049-8041-7043cd97ff8d@t-8ch.de>
Date: Tue, 7 Jan 2025 20:33:56 +0100
From: Thomas Weißschuh <thomas@...ch.de>
To: Markus Burri <markus.burri@...com>
Cc: linux-kernel@...r.kernel.org, 
	Dmitry Torokhov <dmitry.torokhov@...il.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Marek Vasut <marek.vasut@...il.com>, linux-input@...r.kernel.org, devicetree@...r.kernel.org, 
	Manuel Traut <manuel.traut@...com>
Subject: Re: [PATCH v3 1/7] Input: matrix_keypad - use fsleep for variable
 delay duration

On 2025-01-07 14:56:53+0100, Markus Burri wrote:
> The delay is retrieved from a device-tree property, so the duration is
> variable. fsleep guesses the best delay function based on duration.
> 
> Link: https://www.kernel.org/doc/html/latest/timers/timers-howto.html

timers-howto.rst was removed in commit 1f455f601e20
("timers/Documentation: Cleanup delay/sleep documentation").

Also inside the kernel tree refer to documentation files by their location
inside the tree instead of the website.

> Signed-off-by: Markus Burri <markus.burri@...com>
> 
> ---
>  drivers/input/keyboard/matrix_keypad.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/keyboard/matrix_keypad.c b/drivers/input/keyboard/matrix_keypad.c
> index 2a3b3bf..5571d2e 100644
> --- a/drivers/input/keyboard/matrix_keypad.c
> +++ b/drivers/input/keyboard/matrix_keypad.c
> @@ -68,7 +68,7 @@ static void activate_col(struct matrix_keypad *keypad, int col, bool on)
>  	__activate_col(keypad, col, on);
>  
>  	if (on && keypad->col_scan_delay_us)
> -		udelay(keypad->col_scan_delay_us);
> +		fsleep(keypad->col_scan_delay_us);
>  }
>  
>  static void activate_all_cols(struct matrix_keypad *keypad, bool on)
> -- 
> 2.39.5
>