linux-kernel - Re: [PATCH v3 0/4] Add support for jack detection to codec present in A64 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dfb3lsuqf4yowkovwwi6iiroslb4r357u7ddevntdk72ivxcjz@3spuwm24ubwr>
Date: Tue, 7 Jan 2025 20:23:48 +0100
From: Ondřej Jirman <megi@....cz>
To: Vasily Khoruzhick <anarsoul@...il.com>
Cc: linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>, 
	Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, 
	Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>, 
	Samuel Holland <samuel@...lland.org>, Arnaud Ferraris <arnaud.ferraris@...labora.com>, 
	linux-sound@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH v3 0/4] Add support for jack detection to codec present
 in A64 SoC

Hi Vasily,

On Fri, Dec 27, 2024 at 03:58:44PM -0800, Vasily Khoruzhick wrote:
> On Sat, Mar 2, 2024 at 6:02 AM Ondřej Jirman <megi@....cz> wrote:
> >
> > From: Ondrej Jirman <megi@....cz>
> >
> > This series adds support for jack detection to this codec. I used
> > and tested this on Pinephone. It works quite nicely. I tested it
> > against Android headset mic button resistor specification.
> >
> > The patches are a rewritten and debugged version of the original
> > ones from Arnaud Ferraris and Samuel Holland, improved to better
> > handle headset button presses and with more robust plug-in/out
> > event debouncing, and to use set_jack API instead of sniffing
> > the sound card widget names, to detect the type of jack connector.
> >
> > Please take a look. :)
> >
> > v3:
> > - removed all device-tree related code
> >   (it's not necessary for core functionality, it only helps make the jack detect
> >   functionality of the codec be usable from simple-sound-card driver, and I'll
> >   send it spearately, because it will apparently need several more rounds
> >   of review)
> 
> Hey Ondrej,
> 
> Has it ever materialized? As far as I can tell, this code has been
> sitting dead due to missing dt-related code.

The code is used with some non-mainline patches. There was a bit of
a problem with simple-sound-card not being flexible enough for complete
functionality of audio jack on Pinephone, so I had to extend it a bit:

https://codeberg.org/megi/linux/commit/afbe7688083cd1e3ab98c37e0fe0c28d530829e1
https://codeberg.org/megi/linux/commit/95552b66a269c2da434edd3880f9819c0bd5602f
https://codeberg.org/megi/linux/commit/c15070c220e7425dd0d0445ae0eacdb4a4872ad7

Here's a bunch of patches that I use currently for complete audio
jack detection functionality:

  https://codeberg.org/megi/linux/commits/branch/audio-6.13

But no, complete upstream support did not materialize, yet.

I'm not sure about the direction. Whether to push more features to DT or
just write a sound card driver for Pinephone, that would be able to handle all
this without extending simple-sound-card or DT changes to codec driver.

Kind regards,
	o.

> Regards,
> Vasily
> 
> > v2:
> > - use set_jack/get_jack_type
> > - get rid of some custom poking inside card internals to figure
> >   out what kind of jack port we should setup the codec for
> > - read jack-type from OF as suggested here:
> >   https://elixir.bootlin.com/linux/latest/source/sound/soc/soc-component.c#L288
> > - add DT bindings
> >
> > Thank you very much,
> >         Ondřej Jirman
> >
> > Arnaud Ferraris (2):
> >   ASoC: sun50i-codec-analog: Enable jack detection on startup
> >   ASoC: sun8i-codec: Implement jack and accessory detection
> >
> > Samuel Holland (2):
> >   ASoC: sun50i-codec-analog: Move suspend/resume to set_bias_level
> >   ASoC: sun8i-codec: Enable bus clock at STANDBY and higher bias
> >
> >  sound/soc/sunxi/sun50i-codec-analog.c |  73 +++++-
> >  sound/soc/sunxi/sun8i-codec.c         | 346 +++++++++++++++++++++++++-
> >  2 files changed, 399 insertions(+), 20 deletions(-)
> >
> > --
> > 2.44.0
> >
> >