linux-kernel - Re: [PATCH v3 0/4] Add support for jack detection to codec present in A64 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+E=qVeDw=p+1qSmifXTscOUVSSXnrYFVNY2+-_DcUNXe51eAA@mail.gmail.com>
Date: Tue, 7 Jan 2025 18:24:40 -0800
From: Vasily Khoruzhick <anarsoul@...il.com>
To: Ondřej Jirman <megi@....cz>, 
	Vasily Khoruzhick <anarsoul@...il.com>, linux-kernel@...r.kernel.org, 
	Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, 
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Chen-Yu Tsai <wens@...e.org>, 
	Jernej Skrabec <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>, 
	Arnaud Ferraris <arnaud.ferraris@...labora.com>, linux-sound@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH v3 0/4] Add support for jack detection to codec present in
 A64 SoC

On Tue, Jan 7, 2025 at 11:23 AM Ondřej Jirman <megi@....cz> wrote:

> > Has it ever materialized? As far as I can tell, this code has been
> > sitting dead due to missing dt-related code.
>
> The code is used with some non-mainline patches. There was a bit of
> a problem with simple-sound-card not being flexible enough for complete
> functionality of audio jack on Pinephone, so I had to extend it a bit:

So maybe it's time to respin the discussion? :)

> https://codeberg.org/megi/linux/commit/afbe7688083cd1e3ab98c37e0fe0c28d530829e1
> https://codeberg.org/megi/linux/commit/95552b66a269c2da434edd3880f9819c0bd5602f

I think the only fishy-looking part is using device name instead of
device node here, i.e. something like this would look cleaner in my
opinion:

simple-audio-card,jack-pins =
<&codec>, "Headphone Jack",
<&codec>, "Headset Microphone";

However, I'd like to hear the opinion of ASoC maintainers. Mark, Liam,
what would be the best approach here?

> https://codeberg.org/megi/linux/commit/c15070c220e7425dd0d0445ae0eacdb4a4872ad7
>
> Here's a bunch of patches that I use currently for complete audio
> jack detection functionality:
>
>   https://codeberg.org/megi/linux/commits/branch/audio-6.13
>
> But no, complete upstream support did not materialize, yet.
>
> I'm not sure about the direction. Whether to push more features to DT or
> just write a sound card driver for Pinephone, that would be able to handle all
> this without extending simple-sound-card or DT changes to codec driver.

It's not really Pinephone-specific, all A64 (and probably other
Allwinner-based) devices can benefit from generic code, so I think
extending simple-card driver is appropriate.

Regards,
Vasily