linux-kernel - Re: [PATCH v2 0/6] Expand SoundWire MBQ register map support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f459b7be-169f-4ab9-9cb1-97db6e89a13a@linux.dev>
Date: Tue, 7 Jan 2025 13:56:50 -0600
From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>
To: Charles Keepax <ckeepax@...nsource.cirrus.com>, broonie@...nel.org,
 vkoul@...nel.org, oder_chiou@...ltek.com
Cc: jack.yu@...ltek.com, shumingf@...ltek.com, lgirdwood@...il.com,
 peter.ujfalusi@...ux.intel.com, yung-chuan.liao@...ux.intel.com,
 sanyog.r.kale@...el.com, linux-sound@...r.kernel.org,
 linux-kernel@...r.kernel.org, patches@...nsource.cirrus.com
Subject: Re: [PATCH v2 0/6] Expand SoundWire MBQ register map support

On 1/7/25 9:44 AM, Charles Keepax wrote:
> The current SDCA MBQ (Multi-Byte Quantities) register map only
> supports 16-bit types, add support for more sizes and then update
> the rt722 driver to use the new support. We also add support for
> the deferring feature of MBQs to allow hardware to indicate it is
> not currently ready to service a read/write.
> 
> Afraid I don't have hardware to test the rt722 change so it is
> only build tested, but I thought it good to include a change to
> demonstrate the new features in use.
> 
> Changes since v1:
>  - Fixed a potentially uninitialised variable.
>  - Added some extra rt722 registers, Shuming Fan asked for.

For the series:

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>

> Thanks,
> Charles
> 
> Charles Keepax (6):
>   soundwire: SDCA: Add additional SDCA address macros
>   ASoC: SDCA: Update list of entity_0 controls
>   regmap: sdw-mbq: Add support for further MBQ register sizes
>   regmap: sdw-mbq: Add support for SDCA deferred controls
>   ASoC: rt722-sdca: Add some missing readable registers
>   ASoC: rt722-sdca: Make use of new expanded MBQ regmap
> 
>  drivers/base/regmap/regmap-sdw-mbq.c    | 219 +++++++++++++++++++++---
>  include/linux/regmap.h                  |  62 ++++++-
>  include/linux/soundwire/sdw_registers.h |  30 +++-
>  include/sound/sdca_function.h           |  33 +++-
>  sound/soc/codecs/rt722-sdca-sdw.c       | 128 ++++++++------
>  sound/soc/codecs/rt722-sdca-sdw.h       |  99 ++++++-----
>  sound/soc/codecs/rt722-sdca.c           | 135 ++++-----------
>  sound/soc/codecs/rt722-sdca.h           |   4 +-
>  8 files changed, 454 insertions(+), 256 deletions(-)
>