linux-kernel - Re: [PATCH v3] arm64: dts: qcom: Add coresight node for SM8650

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <44020b6b-ae32-4910-b1dc-95d7d5f10204@quicinc.com>
Date: Tue, 7 Jan 2025 16:52:09 +0800
From: Yuanfang Zhang <quic_yuanfang@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>
CC: <kernel@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] arm64: dts: qcom: Add coresight node for SM8650



On 1/3/2025 8:44 PM, Konrad Dybcio wrote:
> On 3.01.2025 12:27 PM, Yuanfang Zhang wrote:
>> Add coresight components: Funnel, ETE and ETF for SM8650.
>>
>> Signed-off-by: Yuanfang Zhang <quic_yuanfang@...cinc.com>
>> ---
> 
> [...]
> 
>> +
>> +		funnel@...10000 {
>> +			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
>> +
>> +			reg = <0x0 0x13810000 0x0 0x1000>;
> 
> This now looks good, please just re-sort these nodes (by address instead
> of adding them at the end).
updated in patch V4.
> 
> Also, did you give this patch a try on a production-fused device?
> 
Yes, it was verified on Snapdragon 8Gen3 platform device.
> Konrad