linux-kernel - Re: [PATCH v13 04/10] dt-bindings: mfd: add maxim,max77705

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABTCjFBui7HMRb--5R0c1LCzmD8fx=C2wPzu-CPN0pw5FUE6mA@mail.gmail.com>
Date: Tue, 7 Jan 2025 11:58:55 +0300
From: Dzmitry Sankouski <dsankouski@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Sebastian Reichel <sre@...nel.org>, Chanwoo Choi <cw00.choi@...sung.com>, Lee Jones <lee@...nel.org>, 
	Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Dmitry Torokhov <dmitry.torokhov@...il.com>, Pavel Machek <pavel@....cz>, 
	Hans de Goede <hdegoede@...hat.com>, Marek Szyprowski <m.szyprowski@...sung.com>, 
	Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>, Purism Kernel Team <kernel@...i.sm>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-input@...r.kernel.org, 
	linux-leds@...r.kernel.org
Subject: Re: [PATCH v13 04/10] dt-bindings: mfd: add maxim,max77705

пн, 23 дек. 2024 г. в 18:52, Krzysztof Kozlowski <krzk@...nel.org>:
(...)
> > +
> > +  leds:
> > +    type: object
> > +    additionalProperties: false
> > +    description:
> > +      Up to 4 LED channels supported.
> > +
> > +    patternProperties:
> > +      "^led@[0-3]$":
>
> 0-2? 1-3? Preferred is the first, because we index unit addresses from
> 0.

max77705 supports 4 led channels, i.e. rgbw, hence 0-3.

>
> Please move "patternProperties" after the "properties:" block.
> Compatible should be the first thing visible to the reader.
>

ok

(...)
> > +
> > +        patternProperties:
> > +          "^led@[0-3]$":
>
> Same - 0-2
>

max77705 supports 4 led channels, i.e. rgbw, hence 0-3.

-- 
Best regards and thanks for review,
Dzmitry