linux-kernel - Re: [PATCH v10] pinctrl: stm32: Add check for clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2f37dd23a4bf04c5c66aa193c6604f24a5f59011.camel@foss.st.com>
Date: Tue, 7 Jan 2025 12:03:43 +0100
From: Antonio Borneo <antonio.borneo@...s.st.com>
To: Mingwei Zheng <zmw12306@...il.com>
CC: <marex@...x.de>, <linus.walleij@...aro.org>, <mcoquelin.stm32@...il.com>,
        <alexandre.torgue@...s.st.com>, <make24@...as.ac.cn>,
        <peng.fan@....com>, <fabien.dessenne@...s.st.com>,
        <linux-gpio@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        Jiasheng Jiang <jiashengjiangcool@...il.com>
Subject: Re: [PATCH v10] pinctrl: stm32: Add check for clk_enable()

On Mon, 2025-01-06 at 17:06 -0500, Mingwei Zheng wrote:
> Convert the driver to clk_bulk*() API.
> Add check for the return value of clk_bulk_enable() to catch
> the potential error.
> 
> Fixes: 05d8af449d93 ("pinctrl: stm32: Keep pinctrl block clock enabled when LEVEL IRQ requested")
> Signed-off-by: Mingwei Zheng <zmw12306@...il.com>
> Signed-off-by: Jiasheng Jiang <jiashengjiangcool@...il.com>
> ---
> Changelog:
> 
> v9 -> v10:
> 1. Move the id assignment into pctl->clks[i].clk assignment loop.
> 2. Remove empty lines.

Reviewed-by: Antonio Borneo <antonio.borneo@...s.st.com>

Thanks!
Antonio