linux-kernel - arch/powerpc/kernel/pci_of_scan.c:61: warning: Function parameter or struct member 'ss' not described in 'OF_PCI_ADDR0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202501070906.rgqBHsjt-lkp@intel.com>
Date: Tue, 7 Jan 2025 09:53:55 +0800
From: kernel test robot <lkp@...el.com>
To: Alexey Kardashevskiy <aik@...abs.ru>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Michael Ellerman <mpe@...erman.id.au>
Subject: arch/powerpc/kernel/pci_of_scan.c:61: warning: Function parameter or
 struct member 'ss' not described in 'OF_PCI_ADDR0_SPACE'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   fbfd64d25c7af3b8695201ebc85efe90be28c5a3
commit: bc605cd79edb68131d3be5b00b949aa312277d39 powerpc/of/pci: Rewrite pci_parse_of_flags
date:   5 years ago
config: powerpc-randconfig-c023-20211019 (https://download.01.org/0day-ci/archive/20250107/202501070906.rgqBHsjt-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250107/202501070906.rgqBHsjt-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501070906.rgqBHsjt-lkp@intel.com/

All warnings (new ones prefixed by >>):

   arch/powerpc/kernel/pci_of_scan.c:23: warning: Function parameter or struct member 'np' not described in 'get_int_prop'
   arch/powerpc/kernel/pci_of_scan.c:23: warning: Function parameter or struct member 'name' not described in 'get_int_prop'
   arch/powerpc/kernel/pci_of_scan.c:23: warning: Function parameter or struct member 'def' not described in 'get_int_prop'
>> arch/powerpc/kernel/pci_of_scan.c:61: warning: Function parameter or struct member 'ss' not described in 'OF_PCI_ADDR0_SPACE'
>> arch/powerpc/kernel/pci_of_scan.c:61: warning: expecting prototype for pci_parse_of_flags(). Prototype was for OF_PCI_ADDR0_SPACE() instead


vim +61 arch/powerpc/kernel/pci_of_scan.c

    18	
    19	/**
    20	 * get_int_prop - Decode a u32 from a device tree property
    21	 */
    22	static u32 get_int_prop(struct device_node *np, const char *name, u32 def)
  > 23	{
    24		const __be32 *prop;
    25		int len;
    26	
    27		prop = of_get_property(np, name, &len);
    28		if (prop && len >= 4)
    29			return of_read_number(prop, 1);
    30		return def;
    31	}
    32	
    33	/**
    34	 * pci_parse_of_flags - Parse the flags cell of a device tree PCI address
    35	 * @addr0: value of 1st cell of a device tree PCI address.
    36	 * @bridge: Set this flag if the address is from a bridge 'ranges' property
    37	 *
    38	 * PCI Bus Binding to IEEE Std 1275-1994
    39	 *
    40	 * Bit#            33222222 22221111 11111100 00000000
    41	 *                 10987654 32109876 54321098 76543210
    42	 * phys.hi cell:   npt000ss bbbbbbbb dddddfff rrrrrrrr
    43	 * phys.mid cell:  hhhhhhhh hhhhhhhh hhhhhhhh hhhhhhhh
    44	 * phys.lo cell:   llllllll llllllll llllllll llllllll
    45	 *
    46	 * where:
    47	 * n        is 0 if the address is relocatable, 1 otherwise
    48	 * p        is 1 if the addressable region is "prefetchable", 0 otherwise
    49	 * t        is 1 if the address is aliased (for non-relocatable I/O),
    50	 *          below 1 MB (for Memory),or below 64 KB (for relocatable I/O).
    51	 * ss       is the space code, denoting the address space:
    52	 *              00 denotes Configuration Space
    53	 *              01 denotes I/O Space
    54	 *              10 denotes 32-bit-address Memory Space
    55	 *              11 denotes 64-bit-address Memory Space
    56	 * bbbbbbbb is the 8-bit Bus Number
    57	 * ddddd    is the 5-bit Device Number
    58	 * fff      is the 3-bit Function Number
    59	 * rrrrrrrr is the 8-bit Register Number
    60	 */
  > 61	#define OF_PCI_ADDR0_SPACE(ss)		(((ss)&3)<<24)
    62	#define OF_PCI_ADDR0_SPACE_CFG		OF_PCI_ADDR0_SPACE(0)
    63	#define OF_PCI_ADDR0_SPACE_IO		OF_PCI_ADDR0_SPACE(1)
    64	#define OF_PCI_ADDR0_SPACE_MMIO32	OF_PCI_ADDR0_SPACE(2)
    65	#define OF_PCI_ADDR0_SPACE_MMIO64	OF_PCI_ADDR0_SPACE(3)
    66	#define OF_PCI_ADDR0_SPACE_MASK		OF_PCI_ADDR0_SPACE(3)
    67	#define OF_PCI_ADDR0_RELOC		(1UL<<31)
    68	#define OF_PCI_ADDR0_PREFETCH		(1UL<<30)
    69	#define OF_PCI_ADDR0_ALIAS		(1UL<<29)
    70	#define OF_PCI_ADDR0_BUS		0x00FF0000UL
    71	#define OF_PCI_ADDR0_DEV		0x0000F800UL
    72	#define OF_PCI_ADDR0_FN			0x00000700UL
    73	#define OF_PCI_ADDR0_BARREG		0x000000FFUL
    74	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki