linux-kernel - Re: [PATCH linux-next 1/2] perf: Remove unnecessary parameter of security check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5603f99d-c643-4db1-917e-c42ea7bddfff@huaweicloud.com>
Date: Tue, 7 Jan 2025 09:52:34 +0800
From: Luo Gengkun <luogengkun@...weicloud.com>
To: Paul Moore <paul@...l-moore.com>
Cc: peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
 namhyung@...nel.org, mark.rutland@....com,
 alexander.shishkin@...ux.intel.com, jolsa@...nel.org, irogers@...gle.com,
 adrian.hunter@...el.com, kan.liang@...ux.intel.com, tglx@...utronix.de,
 bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
 will@...nel.org, jmorris@...ei.org, serge@...lyn.com, rostedt@...dmis.org,
 mhiramat@...nel.org, mathieu.desnoyers@...icios.com,
 stephen.smalley.work@...il.com, omosnace@...hat.com,
 linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-security-module@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, selinux@...r.kernel.org
Subject: Re: [PATCH linux-next 1/2] perf: Remove unnecessary parameter of
 security check


On 2025/1/5 10:45, Paul Moore wrote:
> On Mon, Dec 23, 2024 at 1:57 AM Luo Gengkun <luogengkun@...weicloud.com> wrote:
>> It seems that the attr parameter was never been used in security
>> checks since it was first introduced by:
>>
>> commit da97e18458fb ("perf_event: Add support for LSM and SELinux checks")
>>
>> so remove it.
>>
>> Signed-off-by: Luo Gengkun <luogengkun@...weicloud.com>
>> ---
>>   arch/x86/events/intel/bts.c     |  2 +-
>>   arch/x86/events/intel/core.c    |  2 +-
>>   arch/x86/events/intel/p4.c      |  2 +-
>>   drivers/perf/arm_spe_pmu.c      |  4 ++--
>>   include/linux/lsm_hook_defs.h   |  2 +-
>>   include/linux/perf_event.h      | 10 +++++-----
>>   include/linux/security.h        |  5 ++---
>>   kernel/events/core.c            | 14 +++++++-------
>>   kernel/trace/trace_event_perf.c |  4 ++--
>>   security/security.c             |  5 ++---
>>   security/selinux/hooks.c        |  2 +-
>>   11 files changed, 25 insertions(+), 27 deletions(-)
> This patch seems fine to me from a LSM and SELinux perspective, but
> I'd want to see an ACK from the perf folks before I merge this.
>
> I'll also leave patch 2/2 for the perf folks as it seems largely
> unrelated to this patch.

Thanks for your review

Gengkun