[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250108101111.11dd98d8@gandalf.local.home>
Date: Wed, 8 Jan 2025 10:11:11 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>, Anil S Keshavamurthy
<anil.s.keshavamurthy@...el.com>, "David S . Miller" <davem@...emloft.net>,
Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, Oleg Nesterov
<oleg@...hat.com>, Tzvetomir Stoyanov <tz.stoyanov@...il.com>, Naveen N Rao
<naveen@...nel.org>, Josh Poimboeuf <jpoimboe@...nel.org>, Jason Baron
<jbaron@...mai.com>, Ard Biesheuvel <ardb@...nel.org>,
linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH v5 4/5] tracing/kprobes: Simplify
__trace_kprobe_create() by removing gotos
On Wed, 8 Jan 2025 11:11:18 +0900
"Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:
> -static int __trace_kprobe_create(int argc, const char *argv[])
> +static int ___trace_kprobe_create(int argc, const char *argv[],
> + struct traceprobe_parse_context *ctx)
> {
I'm not sure I care about all the underscores. It just adds to confusion.
Maybe just:
static int __create_trace_kprobe(..)
?
-- Steve
Powered by blists - more mailing lists