linux-kernel - Re: [PATCH v5 4/5] tracing/kprobes: Simplify __trace_kprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250109104127.f8ee0879730a47f5988de7e4@kernel.org>
Date: Thu, 9 Jan 2025 10:41:27 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Peter Zijlstra <peterz@...radead.org>, Anil S Keshavamurthy
 <anil.s.keshavamurthy@...el.com>, "David S . Miller" <davem@...emloft.net>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, Oleg Nesterov
 <oleg@...hat.com>, Tzvetomir Stoyanov <tz.stoyanov@...il.com>, Naveen N Rao
 <naveen@...nel.org>, Josh Poimboeuf <jpoimboe@...nel.org>, Jason Baron
 <jbaron@...mai.com>, Ard Biesheuvel <ardb@...nel.org>,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH v5 4/5] tracing/kprobes: Simplify
 __trace_kprobe_create() by removing gotos

On Wed, 8 Jan 2025 10:11:11 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Wed,  8 Jan 2025 11:11:18 +0900
> "Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:
> 
> > -static int __trace_kprobe_create(int argc, const char *argv[])
> > +static int ___trace_kprobe_create(int argc, const char *argv[],
> > +				  struct traceprobe_parse_context *ctx)
> >  {
> 
> I'm not sure I care about all the underscores. It just adds to confusion.
> 
> Maybe just:
> 
> static int __create_trace_kprobe(..)

Ok. Or __trace_kprobe_create_internal()?

Then it will be

trace_kprobe_create()
 -> __trace_kprobe_create()
   -> __trace_kprobe_create_internal()

Thanks,

> 
> ?
> 
> -- Steve

-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>