linux-kernel - Re: [PATCH v1 0/4] KVM: s390: vsie: vsie page handling fixes + rework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c3291cdb-f9aa-457c-abff-ce7394edc5ea@redhat.com>
Date: Wed, 8 Jan 2025 21:42:23 +0100
From: David Hildenbrand <david@...hat.com>
To: Claudio Imbrenda <imbrenda@...ux.ibm.com>
Cc: linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
 linux-s390@...r.kernel.org, Christian Borntraeger
 <borntraeger@...ux.ibm.com>, Janosch Frank <frankja@...ux.ibm.com>,
 Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
 Alexander Gordeev <agordeev@...ux.ibm.com>,
 Sven Schnelle <svens@...ux.ibm.com>, Thomas Huth <thuth@...hat.com>,
 "Matthew Wilcox (Oracle)" <willy@...radead.org>
Subject: Re: [PATCH v1 0/4] KVM: s390: vsie: vsie page handling fixes + rework

On 08.01.25 19:21, Claudio Imbrenda wrote:
> On Tue,  7 Jan 2025 16:43:40 +0100
> David Hildenbrand <david@...hat.com> wrote:
> 
>> We want to get rid of page->index, so let's make vsie code stop using it
>> for the vsie page.
>>
>> While at it, also remove the usage of page refcount, so we can stop messing
>> with "struct page" completely.
>>
>> ... of course, looking at this code after quite some years, I found some
>> corner cases that should be fixed.
>>
>> Briefly sanity tested with kvm-unit-tests running inside a KVM VM, and
>> nothing blew up.
> 
> I like this! (aside from a very tiny nit in patch 4)

Thanks for the review!

> 
> if a v2 is not needed, I'll put the split line in patch 4 back together
> myself when picking, no need to send a v2 just for that.

Yeah, that might be a case where "significantly increases readability" 
might still apply.

-- 
Cheers,

David / dhildenb