linux-kernel - Re: [PATCH v1 0/4] KVM: s390: vsie: vsie page handling fixes + rework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D71OMSL3ICG0.2AXYO3UR6MS50@linux.ibm.com>
Date: Tue, 14 Jan 2025 10:18:31 +0100
From: "Christoph Schlameuss" <schlameuss@...ux.ibm.com>
To: "David Hildenbrand" <david@...hat.com>, <linux-kernel@...r.kernel.org>
Cc: <kvm@...r.kernel.org>, <linux-s390@...r.kernel.org>,
        "Christian
 Borntraeger" <borntraeger@...ux.ibm.com>,
        "Janosch Frank"
 <frankja@...ux.ibm.com>,
        "Claudio Imbrenda" <imbrenda@...ux.ibm.com>,
        "Heiko Carstens" <hca@...ux.ibm.com>,
        "Vasily Gorbik" <gor@...ux.ibm.com>,
        "Alexander Gordeev" <agordeev@...ux.ibm.com>,
        "Sven Schnelle"
 <svens@...ux.ibm.com>,
        "Thomas Huth" <thuth@...hat.com>,
        "Matthew Wilcox
 (Oracle)" <willy@...radead.org>
Subject: Re: [PATCH v1 0/4] KVM: s390: vsie: vsie page handling fixes +
 rework

On Tue Jan 7, 2025 at 4:43 PM CET, David Hildenbrand wrote:
> We want to get rid of page->index, so let's make vsie code stop using it
> for the vsie page.
>
> While at it, also remove the usage of page refcount, so we can stop messing
> with "struct page" completely.
>
> ... of course, looking at this code after quite some years, I found some
> corner cases that should be fixed.
>
> Briefly sanity tested with kvm-unit-tests running inside a KVM VM, and
> nothing blew up.

Reviewed and tested the whole series.

Reviewed-by: Christoph Schlameuss <schlameuss@...ux.ibm.com>
Tested-by: Christoph Schlameuss <schlameuss@...ux.ibm.com>

>
> Cc: Christian Borntraeger <borntraeger@...ux.ibm.com>
> Cc: Janosch Frank <frankja@...ux.ibm.com>
> Cc: Claudio Imbrenda <imbrenda@...ux.ibm.com>
> Cc: Heiko Carstens <hca@...ux.ibm.com>
> Cc: Vasily Gorbik <gor@...ux.ibm.com>
> Cc: Alexander Gordeev <agordeev@...ux.ibm.com>
> Cc: Sven Schnelle <svens@...ux.ibm.com>
> Cc: Thomas Huth <thuth@...hat.com>
> Cc: Matthew Wilcox (Oracle) <willy@...radead.org>
>
> David Hildenbrand (4):
>   KVM: s390: vsie: fix some corner-cases when grabbing vsie pages
>   KVM: s390: vsie: stop using page->index
>   KVM: s390: vsie: stop messing with page refcount
>   KVM: s390: vsie: stop using "struct page" for vsie page
>
>  arch/s390/include/asm/kvm_host.h |   4 +-
>  arch/s390/kvm/vsie.c             | 104 ++++++++++++++++++++-----------
>  2 files changed, 69 insertions(+), 39 deletions(-)
>
>
> base-commit: fbfd64d25c7af3b8695201ebc85efe90be28c5a3